Skip to content

Commit a3ba6fa

Browse files
authored
Merge pull request #6141 from plotly/fixup-strict-regl
Regenerate functions for regl-based traces in the strict bundle
2 parents 24474d3 + 463897c commit a3ba6fa

File tree

35 files changed

+23011
-23476
lines changed

35 files changed

+23011
-23476
lines changed

devtools/regl_codegen/server.js

Lines changed: 7 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -66,7 +66,13 @@ var devtools = browserify(path.join(devtoolsPath, 'devtools.js'), {
6666
// Start the server up!
6767
server.listen(PORT);
6868

69-
var reglTraceList = getReglTraces();
69+
var reglTraceList = [
70+
'parcoords',
71+
'scattergl',
72+
'scatterpolargl',
73+
'splom'
74+
];
75+
7076
purgeGeneratedCode(reglTraceList);
7177

7278
// Build and bundle all the things!
@@ -91,25 +97,6 @@ function getMockFiles() {
9197
});
9298
}
9399

94-
function getReglTraces() {
95-
return constants.allTraces.filter(function(trace) {
96-
var indexPath = constants.pathToSrc + '/traces/' + trace + '/index.js';
97-
98-
// get categories
99-
var indexContents = fs.readFileSync(indexPath, 'utf8');
100-
var categories = indexContents.match(/^\s*categories:\s*\[([^\]]+)\]/m);
101-
if(categories) {
102-
categories = categories[1].split(',').map(function(c) {
103-
return c.trim().replace(/^['"]|['"]$/g, '');
104-
});
105-
}
106-
107-
if(categories && categories.indexOf('regl') !== -1) {
108-
return true;
109-
}
110-
});
111-
}
112-
113100
function readFiles(files) {
114101
var promises = files.map(function(file) {
115102
var filePath = path.join(constants.pathToTestImageMocks, file);

package-lock.json

Lines changed: 7 additions & 7 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -107,7 +107,7 @@
107107
"parse-svg-path": "^0.1.2",
108108
"polybooljs": "^1.2.0",
109109
"probe-image-size": "^7.2.3",
110-
"regl": "npm:@plotly/regl@^2.1.1",
110+
"regl": "npm:@plotly/regl@^2.1.2",
111111
"regl-error2d": "^2.0.12",
112112
"regl-line2d": "^3.1.2",
113113
"regl-scatter2d": "^3.2.8",

0 commit comments

Comments
 (0)