Skip to content

Commit a7df816

Browse files
authored
Merge pull request #6928 from plotly/fix6685-case-insenstive-colors-scattergl
Fix `scattergl` rendering when colors include capital letters
2 parents c5fdc36 + a70265f commit a7df816

File tree

5 files changed

+100
-14
lines changed

5 files changed

+100
-14
lines changed

draftlogs/6928_fix.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,2 @@
1+
- Fix scattergl rendering when colors include capital letters [[#6928](https://github.com/plotly/plotly.js/pull/6928)],
2+
with thanks to @28raining and @dy for the contribution!

package-lock.json

Lines changed: 45 additions & 13 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -82,7 +82,7 @@
8282
"canvas-fit": "^1.5.0",
8383
"color-alpha": "1.0.4",
8484
"color-normalize": "1.5.0",
85-
"color-parse": "1.3.8",
85+
"color-parse": "2.0.0",
8686
"color-rgba": "2.1.1",
8787
"country-regex": "^1.1.0",
8888
"d3-force": "^1.2.1",
Loading
Lines changed: 52 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,52 @@
1+
{
2+
"data": [
3+
{
4+
"type": "scatter",
5+
"name": "svg - `RED`",
6+
"x": [
7+
1,
8+
2,
9+
3,
10+
4
11+
],
12+
"y": [
13+
10,
14+
15,
15+
13,
16+
17
17+
],
18+
"mode": "markers",
19+
"marker": {
20+
"color": "RED",
21+
"size": 12
22+
}
23+
},
24+
{
25+
"type": "scattergl",
26+
"name": "GL - `BLUE`",
27+
"x": [
28+
1,
29+
2,
30+
3,
31+
4
32+
],
33+
"y": [
34+
9,
35+
14,
36+
12,
37+
16
38+
],
39+
"mode": "markers",
40+
"marker": {
41+
"color": "BLUE",
42+
"size": 12
43+
}
44+
}
45+
],
46+
"layout": {
47+
"title": {
48+
"text": "ScatterGL named-colors should be case-insensitive"
49+
},
50+
"showlegend": true
51+
}
52+
}

0 commit comments

Comments
 (0)