Skip to content

Violin Span Calculation Issue #2631

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
kmui2 opened this issue May 13, 2018 · 1 comment
Closed

Violin Span Calculation Issue #2631

kmui2 opened this issue May 13, 2018 · 1 comment
Labels
bug something broken

Comments

@kmui2
Copy link

kmui2 commented May 13, 2018

Regarding this line of code in plotly.js:

plotly.js/src/traces/violin/calc.js

Line 51 in 9d61443

var n = Math.ceil(dist / (Math.min(bandwidthDflt, bandwidth) / 3));

Why is taking the minimum (Math.min(bandwidthDflt, bandwidth)) needed here? Should it just not take the min and use only bandwidth? I can see a problem where I defined trace.bandwidth and don't want to use bandwidthDflt.
@etpinard
Copy link
Contributor

See -> #2552 (comment)

@etpinard etpinard added the bug something broken label May 16, 2018
@etpinard etpinard mentioned this issue May 22, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug something broken
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@etpinard @kmui2