Bar length in milliseconds

[nicolaskruchten]

Right now we can specify bar lengths in milliseconds on date axes but this is interpreted in a browser-timezone-dependent manner, which seems like a clear bug that makes this feature unusable. See https://codepen.io/nicolaskruchten/pen/qBOKdQG ...

Basically, the following figure JSONs (which differ only in x) should probably have the same output, regardless of timezone of browser:

{
"data":[{"base":["2020-02-06 00:00"],"orientation":"h","type":"bar",
"x":[86400000],"y":[1]}],
"layout":{"xaxis":{"type":"date"}
}
}

{
"data":[{"base":["2020-02-06 00:00"],"orientation":"h","type":"bar",
"x":["1970-01-02 00:00"],"y":[1]}],
"layout":{"xaxis":{"type":"date"}}
}

[nicolaskruchten]

This is actually a more general problem than "bar lengths", as shown in this scatter example: https://codepen.io/nicolaskruchten/pen/xxwzGBe ... it seems that we interpret numbers in milliseconds as timezone-dependent in general.

In fact, it's even funnier without the base in bars... the length is correct, but the base is moved back! https://codepen.io/nicolaskruchten/pen/LYprVoP

[alexcjohnson]

Bars on date axes are meaningless with no base - there's no such thing as zero. So while that's indeed funny behavior, I'm not inclined toward any sort of action to define one behavior as "correct".

In the scatter case we've long held this to be an unfortunate early decision that we're now locked into until we either make a new major or add explicit time zone handling. The issue is folks constructing their data client side as new Date(...).getTime() which bakes in the time zone offset, then we just take it back out while plotting - ie new Date('1970-01-02 00:00') is expected to behave the same as '1970-01-02 00:00'. I suppose we could have a discussion about whether we still view that use case as significant enough that changing it would constitute a breaking change - I'd love to do this in a v2 but I'm hesitant to make that change in v1.

For bars with base though I'm 100% on board with considering our interpretation of milliseconds a bug. Using the JS Date machinery to construct bar lengths with some arbitrary base would be extremely weird, and "x milliseconds" has an obvious meaning that we're not following. We should handle this in such a way that the existing date-string behavior is preserved.

[nicolaskruchten]

Bars on date axes are meaningless with no base - there's no such thing as zero

Well, we basically identify 1970-01-01 as zero in many contexts, so I could see us just reifying that...

[nicolaskruchten]

For bars with base though I'm 100% on board with considering our interpretation of milliseconds a bug

What about when the base is also specified in milliseconds?

[alexcjohnson]

we basically identify 1970-01-01 as zero in many contexts, so I could see us just reifying that...

we could, but I don't really see the point - does that help anyone? We should just push people to choose an explicit base.

What about when the base is also specified in milliseconds?

Then it should have the legacy timezone-dependent behavior, matching all other absolute position values on date axes, unless and until we change that behavior for scatter etc. Otherwise if you try to align two traces to each other you'd need to know which uses the timezone offset and which doesn't.

I really think that until we get around to either implementing real time zone support or releasing a v2, we just need to keep the existing meaning of absolute numeric positions on date axes, and make it self-consistent. For new projects (once we fix the bar length bug part of this) the recommendation is straightforward: use strings for absolute dates and milliseconds for relative dates.

[nicolaskruchten]

OK, let's tightly-scope this thing to just the cases when there is a base and the value is a number.

One thing that will come up then sometimes is that all your y values (in default orientation) would be numbers and all your base values would be dates... I think we should auto-detect the xaxis.type to date in this case... thoughts?

[archmoj]

Let's move this to at least a minor.

[nicolaskruchten]

@archmoj why?

[alexcjohnson]

One thing that will come up then sometimes is that all your y values (in default orientation) would be numbers and all your base values would be dates... I think we should auto-detect the xaxis.type to date in this case... thoughts?

Assuming you meant yaxis.type then yes, that sounds right. Basically, if there's a base on bar traces, use that for autotype rather than y (in default orientation 😉).

Let's move this to at least a minor.

As a tightly-scoped issue this is unambiguously a bug. Of course it will need careful testing but I think it's fine in a patch.

[nicolaskruchten]

Assuming you meant yaxis.type

hehe yes! My original examples are in horizontal/timeline mode (because I see this as being useful for e.g. Gantt charts) but in default orientation, yaxis is what I mean!

Of course it will need careful testing but I think it's fine in a patch.

+1

[archmoj]

@nicolaskruchten in your codepen the base are identical and the x values are different.
I thought we are going to fix that for only base and not x?
If that's the case, would you please update the pen?

[nicolaskruchten]

Done.

[archmoj]

Done.

@nicolaskruchten is it https://codepen.io/nicolaskruchten/pen/qBOKdQG?
I cannot figure out what is changed in there?

For bars with base though I'm 100% on board with considering our interpretation of milliseconds a bug. Using the JS Date machinery to construct bar lengths with some arbitrary base would be extremely weird, and "x milliseconds" has an obvious meaning that we're not following. We should handle this in such a way that the existing date-string behavior is preserved.

Hmm... This is still pretty confusing.
@alexcjohnson what is special about bars with base?

[nicolaskruchten]

@archmoj bars with base on date axes are very important for making timelines, and right now their display is browser-timezone-dependent, meaning we cannot make Gantt charts.

[alexcjohnson]

If we want to be precise about the data we're encoding when we make a bar chart, the x values for a horizontal bar chart are intended to be the size of each bar, but we conflate this with the end position of each bar because of the implicit base=0. That's fine on numeric axes where zero is well-defined, so the size is always referenced to zero unless you provide a base to move the reference. But on a date axis:

• There's no zero, so in principle bars are meaningless until we define both the base and the size. Internally javascript uses the unix convention of Jan 1 1970, but that's meaningless to users.
• Once you do provide a base, the x attribute unambiguously means size, and using a date as the bar size is meaningless. Again, we can ascribe it meaning based on js internals but that has no relevance to anyone's data. However using a number as milliseconds is completely well-defined, so if the bar doesn't have the correct size that's a bug.

So the only 100% meaningful data users can give us for bars on date axes is base as date strings and size as numbers of milliseconds. If we ever implement #4559, an "end" parameter, then users could also specify both base and end as date strings. Anything else is just a workaround users may have used before we had the correct options; we should try to keep these working to the extent we can but not at the expense of these two well-defined cases.

[nicolaskruchten]

I should add that today, if you specify x in millis with no base, you get a bar of the correct length, with the endpoint being timezone-dependent and the base being moved back before 1970-01-01 by an appropriate amount. So basically right now as @alexcjohnson says, specifying a base and x in millis is broken because by adding a base, I change the length of the bar by some timezone-dependent amount.

[archmoj]

An interesting article: https://medium.com/@toastui/handling-time-zone-in-javascript-547e67aa842d

[archmoj]

Closed via #4900.