Skip to content

allow images restyle without source key #774

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
VeraZab opened this issue Jul 25, 2016 · 1 comment
Closed

allow images restyle without source key #774

VeraZab opened this issue Jul 25, 2016 · 1 comment

Comments

@VeraZab
Copy link

VeraZab commented Jul 25, 2016

it appears that the sources key is necessary in order to successfully call a restyle on layout.images.
http://codepen.io/veraz/pen/wWjPZp?editors=1010

Would it be possible to remove this condition as it would allow greater flexibility to create UI elements that create defaults for those other keys and are created before the user uploads an image?

@etpinard
Copy link
Contributor

That's a correct.

Images with no source field are considered invalid for plotly.js as per this line from PR #525.

A way around this problem would be to have a default image source in store somewhere (e.g. in the workspace) that would fill in the source field when a user omits it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants