From 28afcf9dc6698fec640c7ebf066385e01f4961e9 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=C3=89tienne=20T=C3=A9treault-Pinard?= Date: Fri, 6 Jul 2018 19:16:26 -0400 Subject: [PATCH 1/2] :hocho: obsolete packFlat option --- tasks/bundle.js | 3 --- tasks/cibundle.js | 1 - 2 files changed, 4 deletions(-) diff --git a/tasks/bundle.js b/tasks/bundle.js index b787c13f913..7c6586c1c14 100644 --- a/tasks/bundle.js +++ b/tasks/bundle.js @@ -51,7 +51,6 @@ tasks.push(function(cb) { standalone: 'Plotly', debug: DEV, compressAttrs: true, - packFlat: true, pathToMinBundle: constants.pathToPlotlyDistMin }, cb); }); @@ -68,7 +67,6 @@ tasks.push(function(cb) { _bundle(constants.pathToPlotlyIndex, constants.pathToPlotlyDistWithMeta, { standalone: 'Plotly', debug: DEV, - packFlat: true }, function() { makeSchema(constants.pathToPlotlyDistWithMeta, constants.pathToSchema)(); cb(); @@ -82,7 +80,6 @@ constants.partialBundlePaths.forEach(function(pathObj) { standalone: 'Plotly', debug: DEV, compressAttrs: true, - packFlat: true, pathToMinBundle: pathObj.distMin }, cb); }); diff --git a/tasks/cibundle.js b/tasks/cibundle.js index f6f88ea87a5..5a2310e2295 100644 --- a/tasks/cibundle.js +++ b/tasks/cibundle.js @@ -17,7 +17,6 @@ _bundle(constants.pathToPlotlyIndex, constants.pathToPlotlyBuild, { standalone: 'Plotly', debug: true, compressAttrs: true, - packFlat: true, pathToMinBundle: constants.pathToPlotlyDistMin }); From 048a3d6f90fd82804c2f7bcafb3f02e05f3e1e9c Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=C3=89tienne=20T=C3=A9treault-Pinard?= Date: Fri, 6 Jul 2018 19:17:11 -0400 Subject: [PATCH 2/2] set minify option 'compress' to false ... because it breaks mapbox-gl. --- tasks/util/constants.js | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/tasks/util/constants.js b/tasks/util/constants.js index 20fa44fd695..e7c97906bb4 100644 --- a/tasks/util/constants.js +++ b/tasks/util/constants.js @@ -86,13 +86,14 @@ module.exports = { uglifyOptions: { mangle: true, - compress: { - warnings: false - }, + // the compress flag break mapbox-gl, + // TODO find a way to only skip compression on mapbox-gl files + compress: false, output: { beautify: false, ascii_only: true }, + sourceMap: false },