From d3136aab088a866cc956bef21acd811488df53c6 Mon Sep 17 00:00:00 2001 From: archmoj Date: Thu, 13 Aug 2020 16:59:42 -0400 Subject: [PATCH 1/3] fix issue 4460 - accept symbol numbers in string format --- src/components/drawing/index.js | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/src/components/drawing/index.js b/src/components/drawing/index.js index d8f99f96535..7709be7ad1a 100644 --- a/src/components/drawing/index.js +++ b/src/components/drawing/index.js @@ -235,8 +235,10 @@ Object.keys(SYMBOLDEFS).forEach(function(k) { } else { drawing.symbolList.push( n + 200, + String(n + 200), k + '-dot', n + 300, + String(n + 300), k + '-open-dot' ); } @@ -250,7 +252,9 @@ var MAXSYMBOL = drawing.symbolNames.length; var DOTPATH = 'M0,0.5L0.5,0L0,-0.5L-0.5,0Z'; drawing.symbolNumber = function(v) { - if(typeof v === 'string') { + if(isNumeric(v)) { + v = +v; + } else if(typeof v === 'string') { var vbase = 0; if(v.indexOf('-open') > 0) { vbase = 100; From 5b7b18f59ffc3c4ccb44fd24969ff2b40790c44e Mon Sep 17 00:00:00 2001 From: archmoj Date: Fri, 14 Aug 2020 10:36:19 -0400 Subject: [PATCH 2/3] fixup for symbols below 200 and add image test --- src/components/drawing/index.js | 4 + .../baselines/symbols_string-numbers.png | Bin 0 -> 19037 bytes test/image/mocks/symbols_string-numbers.json | 91 ++++++++++++++++++ test/jasmine/tests/mock_test.js | 2 + 4 files changed, 97 insertions(+) create mode 100644 test/image/baselines/symbols_string-numbers.png create mode 100644 test/image/mocks/symbols_string-numbers.json diff --git a/src/components/drawing/index.js b/src/components/drawing/index.js index 7709be7ad1a..66da24e32e0 100644 --- a/src/components/drawing/index.js +++ b/src/components/drawing/index.js @@ -220,8 +220,11 @@ Object.keys(SYMBOLDEFS).forEach(function(k) { var n = symDef.n; drawing.symbolList.push( n, + String(n), k, + n + 100, + String(n + 100), k + '-open' ); drawing.symbolNames[n] = k; @@ -237,6 +240,7 @@ Object.keys(SYMBOLDEFS).forEach(function(k) { n + 200, String(n + 200), k + '-dot', + n + 300, String(n + 300), k + '-open-dot' diff --git a/test/image/baselines/symbols_string-numbers.png b/test/image/baselines/symbols_string-numbers.png new file mode 100644 index 0000000000000000000000000000000000000000..9ae4ee0f1878e2f51c23533404b53a8a4be59a9c GIT binary patch literal 19037 zcmeIacTiMMw>IjK89;_0IgI3-bC5wYNS2(VC?EoYWQL3g2$C}rRD$FvpyaFwl5@^M zkRk-3%#&;BGru2aneIdC>}+goFf3v?1oiVm86JkV97mC#a0fT;4lWxSDa;e& zpZ^6l;AkP1+q>nN5NP0s6n6U04e(h*!yZ;J><=|2Fxn|K){tX1+k{ zQT5P+gi4zp3DpgQRr-K)Svs#ph~BqnW5s{ zZJ}BUbbC{2bD}(lqeM0Yt1jwt<*kfudnoSFx7%yY{uEvpPW8Nat@RkudA13Qz?Mw! z^|UJY4UMOxpS1I)E|LQd=37QSn}`YzLv?Yokj;nP)B;a_(1w6XYwbR<7H+g z_RnRmj}t5vgPG}9BV?VHJ6|6yMbP(;7U>fDAhgOqsAq7z#TQig9b|dEaC@C|!Mp7? zrf1OS+C$5_(({&_i=UK~^b@5q7`io!+l!RqoTZ@S?J>2lm-~`NU;P?)r)$-=C(6t1 zUwuy(e&f(HBy(H3eFDA<$A^>cv4q>3vu`7yjXW<;3=EHpKSMHw&NFqz{)=}q+PdeO zUhx`-BQnd(n)(^vO65&E-gQ`5OR*?x)(w>xqu8npO^T1dZ{dHEWC@pEj%0jHNh|R( zlFfIlSTBlmH#t3>gWIGo(Zr=iulR8haoatAkG5dUqj3|LzHDjV#Lw}pED9Ce7aaX1 zCiP{@UPpbbO8ynv-q`dXbcMv9`Xh zDAnZc?X6&EW3&yv!dnNt3w{=<&GL1hWh0llFSXk#o4Q_Pt>k->C!@M+;ndF~4d)*Q zHZBI^C4T?;^<-y44NQo&O!pru4ZQxh*JlF$7cXUH+Mv+n6Q0IZ;>O*ofyX8lqoR)E zTqlpHApV2Ago4jcVDVbGIJ2h^bgbS1-fvuEB?bmrcd{@-GQ{!eADDi>0nFa7+Cn%Qc;vQEJKCkT07b`KWb#z zc7zkS&3Q}|MRYYgMabgq9BV%KTTqO?eKzCrt>~`LT9QGrAKzm0<$lxlQd=t$LWhpu zT)#I{KLG3wj2|Y8!w=8Tyt?x9-pG12+8XKw8kT}Dem1VvLFbqb4Z_QNvyc;b^Or-j z2`xB{9Ls5x9-VDEhFK<(9D}^A2-!K%27}?}I?#(f{7J@bT)@J$IQP}xSC944UHET` zL`zY8=B-2|x39R&-p?o0a1ou;aa4|2=f9=w`$jiB)u)mE*z|NETUOCC=j zEm-Q13laJ2*RL@rGBm;i2u(ibv3f;!0XDkO15 ze8O$A-y|+~tMxL{g`Qfo!#%en>fV>PowB)1RoV65!1iNlB^AwxI|Re~7`7vWCa?=gIn73 z+jQf5pNtv2vCQwV!EzQJczg0{&=8J8VapGrf+z+a4=W{kSz%e>N5h1?SQT5*ahBS0 zt?~1`e!^6z(Sv%IAdR;-mt&Ts-1u}-h6Kvt@cVb^sPM(Sen(?NcD_-F!N?(kYWT*f z>I76mpV)So)sjEm_LSZYiQxa)7Q)~8Bhv5BchM4Nd`9U`_nA89XD2Ne(bIz+s1 zcA+?-*dAqiCHmT)FdqEwbKYQG$m^7lHlh&eU4rsyOjD5m&ZM$h z>rd+M=ys22o59(vXTvU`w6vMLOtA=foytUccpv`yxNzAc>?0(on+YSq6vK-xfmL&z zSikfK{lNl%Yy0OO0RnqT9Iw{lVK`ZMM(o<1hT#L?Wn`=U3SNWZFZDg$WzScP(NSYl z z3&-D#J}*CnTN-ty)>5AY_r5nzWu|VUpvexr@fMa7#*!GlTzp&8UW==cFVES@c zLDk_qp+vx2O2$xfbnfI{F!Z}&5xq1&&AAj7@1WV2YhW^&-^Eh$YW#gZ2r(zyeH{== z$tfl6W!cqYd8`+SoxF%&7HPv(N$K4_(D>(vWYQTf#15%jUuP=YFr7F60)DCI*Lj)wq zvBX}ol>EZ4yor@17F253>XM{Q_U98@{^Y2F&M3iZYGX6hRfe>*5B`oAY~Y94aMKFP zmr63W?scb&^!K#JoV>)Lnl<-=bpsQ9&W?dGz!Yu}+R%lKZIdf^Nf0k$XwywV-MZ2t zKrsI15N7$4ADi<%_ZEfAA!N9B2nI`h9WnEd0b0b-?h5Uq!4C@Ev=%3%sTkGrYlI9C z8>$AglJC5vmLl7I;|JDQzhv8;sGw0*RizrM zQ@|!*C$I9cT;E(C6!W&085YYg@F#b&!}m8s?RZ{@-d-OB(hFHyg+SY_ci&iUVeE{i z4l9}vN1nWTX-IJ|L}uLb4fdb}KeY%QF_#JjdNUFE&Sx>^^-*;GlrUjkd>zC2R<3>+ zPD7(1!$WFqrN~(Cr(E$rp5wpl%|BPZ+zs4tMM^`KV0iQ2 z^^9lsvAEF-XlP5AtWpt^-$KYEzuIS?%i9otM-O6K`5RqF6{JFk<<_ynwl(R=FhnXP z<#mwiWMwofHXc28hi3OZ(u<3xmyVU|#Rr-Ya(m@<Or@$xv zwQ8ZrBKw$88qCjUZT}?m1Hv>D9z21Z`dT?06+z_qiMercxWBDi=14?j28Qj+_50z^ z!^-C1LXJP#Dhye3Fql(zMoKFmB7{5HsA3}oNy%`Rd~t~nPgtIiHL9X~*_N;~7TJp4 zIYM=6!Pg`jT)FFD&Y&6^!q3=M)yG-hOuS^a7>A)TyL5*02~Whea?rXqf@lDp{kd6^j2FTBV&mm26~WRBTGK&5wZ*VQP7HHt#!hYMyE)V&09{ z#Ug=aDK#jjL&0qsLZ~KVXy5jQh3?r)d3-j*UtNf367lYEqtb63sfOg;i!s=^bl9gR z@CUsl=wXL(mWn|OZ7T@c_`7QAFi9ID^lAyOyPJ<*3{*<#UlACM68TcI5%xUiC+Qf( z4dHJl@Ol6oOL!ag^NL~n6_?j9J#BJ3MhNV4C<^Y=y(r)Kp7GJ%U5qLU8DmrWH2>>j zD7oZ)Gz!D}#ocsK8FV=PVSI9{5qD{eu_*9~DVi%G+jZDzZSD9JB&3-_?d#&rvNQ)m z8pl@Qu~W<%>TT3PJwbhF@&v36i&@D`aKoIQM-mguJeUT_CO4GwGZyVv(v zX)6Q6zDC(}c85au0%H_y?`A!QJFeUjp%2p{~dj1S@0f6zMFfQd#|u`lZj;djZ- z(3DJTqpD`I`4EIn7T%E?5%kTp(QVr*oIC`!a}XI)2&JGyClM(b4&wi0ZPX9ok0}0C zB=#Z44IR!=Fa_d@jK}m79im}KY~<-(ic&t41OX6)S(%RMqeDtr6xs?0_%d`}AG;{9OuP9hHhU+m|2fKTue?`{mtbZQr%5}B?f zUtcFC1BTvj6Pu0PI#@;d(4U@WO(9S&s})a4nE!oiZkP}=F3x<;9Y=gFiqhdBK4h-C zevjCkX}dtO{9$J9Z7^%>;PT5Pq8EOY2|}Yp{=@?b=D0W-D$9RcL;God*7Lav#Kx1; z8-B*XAc1q)SqX$+$R*+*^c#|$>L7ma+T>s+aC*^wl1W}U%v?zm{k9Xd=0UU31#EJj z81lXEPjkdeOb01Mw{b(xiBR$}pKi5J?o}z_00Tr6XECik6kn}+@;m}*-Hu7rbLbh# zFQtj)kK!e2!m`plGL3p3g=V=J-CQgvS9yl z!vb2c5k>OD3a$t{Y$+$Nos=MqcVTx<=_;in&a7W76Z^^;8h5P48?tndBzt=c8BNo! zd!ky(1~=ws8E!;Szx`!p)et78QS-3;^||I>_M z^u0O=yiMRS`=b2ogSv2W(ks2b{{DBPqmS9mzSO)5b4dIHNF63#Ud{ew?h@_K%_aRe z*O$zak|uy!IWW6FD6R$OAL3AnOanwb6m*XP1qgX;Pss*>D(9ZF!;cX{+ejXRFuKSA zgz#W2T3)>NW{`s|K4I}g!cO#0g987${TKRs>^yDkmyI092ve+LD^F5bO!PxSc}5#A zt$RLjI)q2++I)*IW;>ZnZ*Q-d?Op##D|twzT;E4AQdkZG`!PNy6a4orX_MUmnfPHR ziQQ1Pw5vgZVhmN4)0BXUipp!rx3;Rvpo{6KCojqBv7sIsxAw(jrvT7K?-CML;Ci;B z7biOd#d;;9hwfNJ&`8A=BjGE64> zvqN4q%ubnc*+g(h@I{aSBSyijm78rnE9OIDPTTTp4H1nN6ZvJ5IGLMsxuZXS3ZKt? zsf;>WJ#b$ijDJnST3py9;ym5!TtCNBsG8(f$OVn$q}a0?$y0bkT<&4m;#2#$+H9H;$ZkGZy32$zGpes@sDxn$kK{Sw6O{+?57WbR&R>GE!9Z z#e+gsO=S+IYfE14jDI%|g7i!u^*lHF-940Ci!d2pe|L&kJkG=GTqe<-l8nI&U+IoX z2q&QKr+kvRq$c@2EcZJ)7Jgh0o$n*S!Y~j%IL{S&HmWS)xx1-q#s)95tVvM;AkXgR z>hCFoNoTsKOE!v^!(Cf4SROLJHTs%!sr0Zb>+eGN$m*c+Kc{^US`7A^4!(v)QHwaG z!gKgSPfF?r2Kg6Q9*?E>(6OYZp^Mfw3&N5FH}klmmxGo9itrGPvcmtpR{ zoJp1KYc8`dkFQ&F3RO|W9&YnJ8o~Xa??Ybh&l(96eDei2uAMCerW_x?yjQOO*|^GK zn1NCzpt-fW>)PA@;#fOSG~(&64@J69L}y=wT%44DyWw~%brdP}XHd|yGKu0X+A>tp zH%$w%>nhNbhZK9VZUBWwN{^(T{`vuT#se6xgb4ZoL+*Hw?NRnT9h>fG zZSOkA35{#I0Yd;f8&L$xDF;0x8D{6b=u-iHJmsG87AC+2R@vf_u>zqlj(;?X*hS+3(IZK5I=uApdA4!r*E+>g!@wITflXJLAm+1 zKS^W<;P&W=UR@k-Rk^MxHlB=|j2(OfBw?)|w2d!9J71CgP@vox@yLECd#}HVixg(^ z*2}5@kb!;bqH_hNUDZD%24wr&KiNYX>-O$E9sAv!>b<&lkfQYDG=4#}99oO4Y5tU* z>8E`id1`F7aWkwY)7KwH{g4|@F7!=<$6;6))&1*o*1k(MmIz}+9&XT>9*h0Zn$|rS zmt`fSoW=#-{_O96% zUg0A|h><mge)JJ%PnD^P?X68x#nM^wG_eXsS z5Kyyj1Kb?b{YjijDLS+Hm4{+VF~DT9G`@Xsp&W2^sMKaACWfg%$Rr{LRW86j8tb2e z8oLe&8e!V5q|+Y#BHvjnEqVK9lPe+}JD9-H>79l9ci|}XQ$!RV&W$Iag4tXE{Y3=NOaZsSMR$hW{i@5LbO0`nFh4w=%p#o~MJtpXFY zuV&xNqkpWZC;+6GQeW+aIrSx^jwl4p8l9N*3M^86!5~}`mQU*JP-UkVq;cqIXop^Q z^A4Dw&yVZ`pg5=E_76^Db_b@*W36(2owN@BkyA&!h=Q{2yeObt>0R!6Lr4tE9B-ct zW*h=6mM&{0is}?UowOP2W6x|y5ys4dg1U;aH0-sG6Ui=L|0-4_VlK6Aar%9)@xKf? zn~M{TCAOKu&p3r;FMq7HmiazxqlIva>lj>&;w;k&@1n{#LICd5nK7cB%`l>q=&M6W zq#jGx8REhDBKnDd7DanrePGI3&b@s*A!h^K^x6_yZRgS%YZ1LG={U^tYmSl>C-%(G z7Ur5%*`D$g=_PbdgTG;ezVLFJH24cM(kU+(Ob$dqx@sOInSQvl@GyFZxz~;Tm7xw8u9p{l_T|+lA&2$ z?~$F0VKE%0+2c*GT<%pjAjKM~sCF`P0xq6DL^}eB1?;1T@2a2cQC$8JH5hpNXS^g( z^jmIhO+&7^yhtjMtW?xc_=B`&9er*NsW1$}N4 zPv-9L)R*Z8mgp4*9q;fd_S=#MaL#hUQ%mt_sn|shE6y0d=g8c0A4naxaBTP5aHvFl zReuweb=J>e^jB|b^?v@N^b3=u>9CJ?)l|t#=GRGlE0@V`eMg%rob211D)K_|ke!=| z5G;asYXd3dwB8-L*rFs#OD~v_39Y(@5&P_1a`Hbd2A8!>5$!(FqSH@{-?H2=edC$q zN;z}k(Yw`SOU9AlvJ&@x{@v9(&6-IZ8rhNkcoyCDT_&2_CKTraS01D7w^a1kglJ#5 z19kJC&w+c1+qY58E*xx-r87ikwEpR`4zSG}Q3{Ys!sv`mKSCx+$;;fPxnN@0v8n0K zlI>KZmrDoBy|5sPPKZ^HOXSn@>MZ$uK>lpEp1lBjl`7Y4XU1lBKQ0k%a z7iA92&en$z*V&L|O-r&kiLuxu9rn|&&+4o$jf3JsjSw6YT&!D#j5CfN)CcosjaBXg z^ICYyNl@Vex3KLxiGeyZYP+4Xc7lzH{h&mi3>G~{gGh(+G3VyX({*U!v4XN&m?A2n02!Q-449 zlBg>jE#DS=rZLxCt#grg(zsb(BTjxv3Zv&<3r8+W6F0|Gg)eq{>^qk`GxgLLQHHM< zr*wH`H3{lsa=*Lj?L%V88&vE5iP1a4u_o_;Z!8@;G6b=+9(Hx%C%-Itb_z}cYKY6oTT^6WqrXwhy z{Z#M#`Xv+xv-6imI%55*z!~lL!??tp8iGk>A~d&9<+nrfaHh)k@;?eJ7I_bzQoluF zT&tMuDzsc|mjvTc9MTetqD#X>pR%Naw~nOO$n>pN4e%tS2|oGq3S}+;*Ulo%OvD5q)_qi~c79VWd9g@O$x3F?V!Lz6xnBW2aBgtsQ zFLM4=dqE>}YOZ77=_^z>R8f;|XX`=INych#>;kC2*8~=G0)K zKhMLSJ-cGdMq9>STkHp~-eaCLC^~E=dgtxomsp`2e0KO@HJ+R*RJm23BOr}ozrBh& zn%d7hNdTNf?LD6^upMZ znBCAM?DYTOx}gktO>M?Ttb-8ZBT3GKp7vP8*Nj{-ynhWM?whhzA601Nj&f~(99mwI zxFIDuz{;k`O?@&_SiSOg8X+c=S5v{_iWV-G>DwP#${>o@*33oz3wA&b?-X}%vBU2M zbwz4GTvMJrY}7^&w}14vhARJN$wM|cqC+E_q)7T>(B8ow?2+gqf<@zv5b2McteYOn zcwSbr@uXDTwaiCO?mwJYDnNP-iS-h*!DUBopM0OM!Cp>5V*FK^0og0OuaV~<<);P$ z@EWHn9S{WN-|Q)ZDIz;uD8&Zn2^tlm22F_*O(k20cN3V+9O=$Z{6DYN(yizJ& zo)>&>y#MQ?W(ondh%$gdX8Zt|+>73~1?DCqzpPOU5nLagghWUM`2H5{8|Y6MttxUG z&CO?!XEKM#zVQI}%LbhPUK;u0;V2H$RsWm&OLxENxYe(d>G8Fwei8Dku^PT@;)Vx+ zxlUlz>{Z!(bu@4U(pD?^EsoXM!)nJ!F1?KGqfj->pb7eP6s!J1&f8EKB6>H9}!injSpuX?f!2+)rF1NJwT-7dLt>~+3 zpDBKu4|XOmoJgI2^!8RnCzzLf01p(HaJEXaf}s(E?%b#QvoZ8`@()tl{zpw+1_=mL zGJmS_?N9SesEk|hK*lsqJyZ3wRncpQ3_^Skr_~VtqgX6#ATO6Ez;BK9F;}7UF(g5UB4T<>#V1slS0edx4o&>E#{n&8JNwj+-a-BKL;bB}- zQekKQ%dHV2;WtS?HtZ*Pc=TI7iwxToR+~X`7}GJC(qWdjjQ^q{=(Vd2x0;=>Tvj|% zc%=!>H?%# zfJ0iYJdh?u(At8S(+#BB2j1|0-Q+7&=7M-{PxH7b4rPxV*XS}H#U}l5Rq#`VIU?qy zoYNDZj~a4_NH4|xMtBCCwd|TynihL(Cz9^PFk@WSIj3X+Wx*KF7cFYS&W~k*y`*vw zSIcc$NzY!C7zE_^Q%cIePNOgmGcF|d{6^d>l616$lfWWSPKQ&UtzU)`v(tfh+UUuM zZJ*QZr%x@Fp*{RwImC&N4|dl$SI^2OROWw}>9~*fM&_4TIlHK!1$&mYl)VA{ILbZk zCZ^;4UfZm_5?bxjZ0+6d&7_7!3ZqV*ZE(#;2{z#H2F<|5)*ziCox+E&q&No@?}llM z%+H!trEqEAmhtanvd=X)UYupWnvdu1*yrwN&0nh2xejyHDSo&#U8yHAgNaRgc(9R^ zLOb*=SGD}5+AHzhWRtu)@;!Oq;pZ47FCoGmo|XD1Ka3hxMLfS59lhG)=`Y##KT~ad z!+Y1m_l(v1gbK_%r0|&<%l0Ai{7|ZA7dJ>YkKxW{`nr=q}RepGWSM?FZ zwUuOo&{EL9KapL)svV;i67AvKv@}HhoQpUvoupgM{tX$&);<7lzog~fRIvvhcInu) zA{lr)IkM*5LZa%g8#in(tA~n~3BT1w(9GvYT!`8i2F|@qSUs37y!rOBBV5Pk>OAk% zxDczlKBHRgOzXLb{AoyY`j#81sC5tsN(kDb*Dk_?5H85MP+$*|3a*L3Bu&WyX^ zcY#+rr&wtx zb-<%U>yc=)UWpOf+|u5sa7a=o$?SBCxbcs)Fn)4Tc|Vr=g+-`u#U zpx+$uVvxTFM_+puhZH8tHa!@EM(q9Zo&^(ry=6Bs8ZC&WRd6awzm&alDU$Yd>Lg|? zB`rs8o~q0kRomk}upg^;vB=0LJ42X4))ZNY4AM+J(~NILu}fyWZuRTW%M7&Te3Sb6 zSk)S>>$i>Px|@{dmYbAoMQaSwyBAG(__(p zX!*dNcF)1P87)|3`$)xvt1yOw|Dn(E=Kb&K3OxDUl3$0>U#FPTYSxjR_hgKcng zKO*{Y8h$9CzYswP9I7Ae$`1bl34e-M^Vt8fSCW8Tb^2vzbl8oix=d31XidK!v-3c6x?Mo> z)qWzN?TRk@_M87`Y;;Gx3;q`k)#@B^`TSn#^A+Kq9s$|Z2W(+$lqHrP)aBw2l3Uu3 zWsBZT19;(LIP=C%kE`4mQ<6ThU7#$7J~65hd!!^~6yVE=Q$%TU#nn~8=cxxf6XhxQ z<-*zSy8`z*o4ct)2TrTOg};Y`SbCoC(1-Z&gWQ{ttAf3#dz=M;t5RyGFG0+> z3`~6txco^IzmQG!k2j*4D@rAuu9Ph=5wJ$1$+KtClh8%16pC13@*GwD9#e1j|$3T1TWb3m0^83 z%A~MBF>F03CKKCH*cuiyTsB~293C5j4(MO4OBq7xV;CmWWZ9^%%ck7=LS01j8uiP4 zaKxRPfIL4@nL!b##ew{052f z?VV8n%hM#F>y)$#`Aw?djx#p^W(S=bt$QA5J1O@cBuK`JdV~MR(*QFL1_U5Br<^~v zFQJj;4gS2*Xv>mEk!S#)UtTqau08nG;9h|2jNu{01yehnecH^>)3FntP(lG1_C&fbKB*vPO5HylL zF@zHsQ5xTT+h)U*UUFPPLBYQY4-+UsQ)gRwR9XljfpBa9#=Pz%8DXh{w_>~jsfGUO zT1RfROu;9ynJ?OLgNN*m!+;!9wZ-Seuhip80dS?7>q9v%X|m6smt6=s0DxncDL5ph zJ6-2Y9mwqWh_a+5_3v^9@j7`^lmYLfJu`sdAEgWRy?YT5@HKsJMRHmHJ+Kcb*)9F& z&b(PB1jIGLKDwC?mMoMzT?Bo8hChJxIcPcS_dlC^^3f>S733CJdRg(8P|@z6(&`_o zy+W`@s~s>65V6tkDMDQDW}q!+rdhDF!2{yQ>w(*STgQ*rYvp`5A-Z_HtfkR-MrMYm z(ZqeMynQ<;(ebgyZyVNKqe`XUAuxT2IO((_S==$lmfQJO#0-D=s#9P5H}b2`%OmKO zVUK2%N#iI!v{CIRvg_KO?oPc+N%?q6e{pue3)ZW<)8lF+jqoPh4EnYU;f=mfZnz#I zw&573?QK@Y({+|M%~Z@)Er)U=1Uz-~mnRwv_U12Am}JdytQ_RERSw|z`y>yV8B@%C ziW0d^^v%83?zNfSoXxtwwHeSsu)&8V)D1BK3+08Q`~?F; zSoNYSc%@-IauId7Z1B74fP0BKBz_($oah&*(jlAO2jivHy#pB1rp{uLF=|v}$vgC&62P8DN+~O#w zJsvafz+>luzgqCGr)>`E5g(n#gR~W}6(gfB)T?gAemf;H!M%dUpSS8U;9tOUk&_i& z`*TfpzZcuwfNFA}=wtRXMulTG=Di?NZmWAFgsX`)YKHkx&E?cC^xGWpx61f@s+!?# zBu+}jGMzw;CLlPh82scY)Yt$RNF4uc!fLDaJWnaRUA0c#4*Ws4vc}@`utR~3SQlZP zx&=hw39Q*(%ej~7Ab-RNT#K9Ssv(+nl97N9oHtw?cH7 z{dXYri5z;xi3J}N&F8G2OUa9JEy&24s6FH5S?N?tR=vo5oI3sHYxD!>d%J#GQ2#Xg z#3NUjTO%73xsytQ5zN5ufnNaa{@b9xAgMs(Apw3LUnqW; z4gUJ)FBxu3`9SK*@E?FO$~-(062a`$Z4P>(0l}TcC`Arn0AdDRokD^rL7c-Sic2EGZ6M(x{0~&(6S0c=Mw$~F3lDAw}W`@#n`9nl1Z%q4JiIr4U zql~*bpbiJw>I@W_Fpw|sFn*mV`LF<9{^_aVR}MC|xY5zkUh{exlhu^Bc!A{lgay{> z@y6T?({Jk9yRo^ot^4o>8gY&hS2RJUfVH+J*=i5Nvs>+r7qB0scnYH6?~l9k(l85F z-Y}?_MMlCrNTgZSY)87n7>Mm5;+J&sf;Z&D^QEO+!l}tTW*4mocu@KIedem;u@`vC z)sFH!{>Jh;QPcK~uWz;(8QdcxOb~E7vjw6)Hj`2F-M_X^o~ZpjT4SUSrC%WS{(}Wo z_REjdFJgm>3?8m$xb%bkc@bT> zHLB>UQ>PNp ztZjCOrGbJZJPdT40~A>_19iC;pxHnYs_l^ize}DjA{6aNv*$f>(m%N7trGB}c>&iK zsH!S9xM!L+VlznIq#cBV|M!0#(1Kr4?uH*5@FpeJ=9Fw+^7`l;X`Z{tj{q%8pYVh! ze?@-s*bvN?vR9N%|w?{Y&T3 zRWinORjN2i-Yhu3e4WTV=$aypI1{UsBb#4nZQ7&)~{yr<#I*(--$Y zl8LIBH^qCt!51>`r^jQyUVHPH7WzymX}0V@iOb5U1zTtPa)N1ZZU*{m%=z<0&79V< zq>!hemDB_bEbSDO7i%go5@*9=C2ESq1Ybtz>W1d^ASe?2m8t!CFbit zN_gT~FY{M3{|tqH*?SlAI`vCHrL9Jz{Jm_8Ym6!1@1;19N{O(f(-k51>$W`(+6w{H zOO=_5H)&H2VFN#b9S4H?J7jroxSVJdXNa4&HfF8}!gpT*lDz8#$iF*p(Asqk^?SU) zF+G!izAl1hG8}FB4jJG_0YiV@8p zuXAi7b#=hP&Nf2)HkaRm5*2;}LVHwo2dDvA4_a9HlE9pBclL;CyyVe~`_^k0M0>T( zF|YQ>88~kmEqO}~(uBTf73@F#*XfyZhK5L@`{3;2`0BbD2slg)ez1I{!Zh8e0`(q~iNt_0CWqLbb8OEqCjCRfkjDI)uChH|{RThx!NykNE z7(&}MDbSv$UT--Mq#L(j6UW~f@ay8q8m-&PFo^QI3AH<^2n`eY`0=BOC`6QK#acUD zix`E$MFK|j|Iv#92>PGOvj3eh4ci~6%X}Nm?m;7G>|F()##;^nc33?2?1P zgE69V=y1SUiQECb%B$SOfi=FSMKF7VZ34CWfV}M=0EPWuL~mO`KhcLjp?@(2!ZjZB zF+NFv(-eWc?H?hTGywhr0|;Q5(YiDVL+K(FX@9O2|3r7C{1iT=4W0)5cLz3u{sWT{ zvjzD4|E8n+U*G9H_OgH$K{bk7| z=vgW)ASUv`8~!8qqXX)P{*) zZ06^8tEj0ZfRa@ez|HuhfGOcfycDo0KJD%;0qQ4#z?-X3RnrQ~pql4%67Qw1RA<=?&CrBpmxdkrbEV@>LvlTI%_% z*cQ-5KJ1$FoN+z^v>8)kgvD!e9#b|{Uq3aVQ2F}zj1(=pM>I4bUVXa@Y7&5Ad9xih z3yXV_4Io#`$vB^oLAL*?(biP;lZPGz2}r-2zZ<9m&CqEzK#Ex`0#fWjdMg*4QfZW& zU5~?li@i{X`PIO|yPRr+E`kzdfk6o;d(pU>9u`iGD6eD0?yYagg`OcM(_RJDJL9@{ zq^lcUHLkMeWvkE4OO`?6NYySe{<;5+eajA21JAn74UN>rVE0j9w zWqfvvc1ak5O-NQcCqZBjDe~O1WOqMi=dWh#{hqAuf}h|YScYGVr14ZFFY-FN$3MfV z1D~;%;cf~%XB$P+xmnmyUGtPy(6QDe_T#*SF z>#C)sTa_Q-7C>#5WNg75QQIh??>@Fr-+cLL*XUH`6K28e;S-gyHy1O{4i@k}^u`W- z3^hgwJfq)gp76&vgVq9q*W;`PzA_4@MtHmW{?*JR4 z+UT}MW0VTK!|QP?Hu$XkE1@_C(lj*U4hs6ftI8uWK>Pm4O9k@8crX>zK(Qrl+Bb^-RX!{$!{<$9$%ccA#FeE~!SFqy)i&IjK5gPJ*uQQ~Bx-`(dx!^H{GUI_k4HULVa96UDg?NgK2a zI9LiC4l9La+#W)ERamo_KwY|iu4lE$IneLgZI2e=;^O?{n2{Y^|Dg5GiY`!t%=K3K zG*v<)3R&+c>A8z4#!H6Y;}EN2N~vfFz4y7}1!1T!JQj;M1`x^C6zCc2hCc0h*4^x- zpfdO&UBJ0jk9`4Z|OVDJ1z)v`-?Y=2rS1vS@`%9NC0|BOEf zaR_OsSV7qBKm!CQCRW`)k7>h^P&iKpMNkr_J8Jv z+h)A389uv+1IX?iqH78yTJ>D6pj=xA(0;@#i^fS6en@QAiGYhO)`8RIZ2nLk=2_Kf z^0DZYF+U+aQ-zkJeoldatMkxl-`&a{=+_|Pa3o&?+u8r+h_wEz*TBRWpa$jsherjrpnGWjOsBFI>2<+fcs~Sh_|2fwr1TB$A zm33IbfjOW;2SU^_KXZYHK302lX0OAE9zJ5?3Y++OmF;T~hb4Y{^=C)`_=vxI^$ScuGFjGq zq`C$4&RD{KK0pD!O#r;3%GcW)UlmQw6kzaGfp+(9nwntC`{E~Mq%eZrBd~jcDj=H* z94E@E+}2c4YEabX3M!Ya+(1d)9ZSoJs_0*dmE_sNv<1=$of3U+VfM*7=L}SS8Km0_ zr*ooFLQ@!x(Q}aITU}c#s-trs`Mszdy$UR72}M1~Yur~a>&6AjRCm4KRmJ)g6E zZm_|Iv9@})@4mSB)$fi%-H#fOi61k|gu)Q-%e{KL;XDPD1OacpRfe?vN0y}BNP)_B z6Z{n@MSlNtRjxROG!FS4@T;6<4G&o~vrUhevYPh4sPQx`1{YW`$|Pc-i0UJdVJSi< zj_7Cgi&4TeKaIODml(&#L=NUZ)+r52W+Mj5A3kVUS*bXJEg*F2oQw#bZJ6D=dk^w= zH9>PUC`e90>IF^9zf*a&rV(~csH*&2*^uU)M}y)pROLs764@8uv*#yty;XJtiR5lG z&hs`7 zn*3Ae^pyyhtnhTqc(8>G!VMfSrASXvp;pK57(lFvj&em}C?hf6feI+5#@)Vgu+K~! z(gl2+ukY<;QR^no6dd%~Y1W0KuJZ$g;30u99s^iJL8}Z1hzgHyl`!hMMQSh#E}x8G zsI6*HL!#_9mGJpKYOyVV;NDN}doZ|P8QusE-VJ0s5umO+R|GU3^)s@6)^48y678Mo zsjVaGx>ivTzAb1~!%yuk_!1; Date: Fri, 14 Aug 2020 12:31:09 -0400 Subject: [PATCH 3/3] update flaky list for image test --- test/image/compare_pixels_test.js | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/test/image/compare_pixels_test.js b/test/image/compare_pixels_test.js index a80d2e65d51..c1c0db82e9b 100644 --- a/test/image/compare_pixels_test.js +++ b/test/image/compare_pixels_test.js @@ -102,10 +102,10 @@ if(allMock || argv.filter) { var FLAKY_LIST = [ 'treemap_coffee', - 'treemap_textposition', - 'treemap_with-without_values', + 'treemap_sunburst_marker_colors', 'trace_metatext', - 'gl3d_directions-streamtube1' + 'gl3d_directions-streamtube1', + 'gl3d_traces-with-opacity' ]; console.log('');