From a6a5ec27cfbbcac7490b6e717e0ffa882356f1b2 Mon Sep 17 00:00:00 2001 From: Wei-Wei Chi Date: Wed, 27 Mar 2024 15:44:14 -0400 Subject: [PATCH 1/5] change color countLabel to bandColorCount --- src/traces/parcats/parcats.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/traces/parcats/parcats.js b/src/traces/parcats/parcats.js index 44a23d20d8e..965cd93e3d6 100644 --- a/src/traces/parcats/parcats.js +++ b/src/traces/parcats/parcats.js @@ -921,7 +921,7 @@ function createHoverLabelForColorHovermode(gd, rootBBox, bandElement) { var pColorGivenCat = bandColorCount / catCount; var labels = { - countLabel: totalCount, + countLabel: bandColorCount, categoryLabel: catLabel, probabilityLabel: pColorAndCat.toFixed(3) }; From f019f6de133f81dae69f288af2b243cb388cf4bb Mon Sep 17 00:00:00 2001 From: Wei-Wei Chi Date: Wed, 27 Mar 2024 15:51:02 -0400 Subject: [PATCH 2/5] change parcats_hoveron_color to include count in hoverinfo --- test/image/mocks/parcats_hoveron_color.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test/image/mocks/parcats_hoveron_color.json b/test/image/mocks/parcats_hoveron_color.json index be40fe56d8d..499dca01514 100644 --- a/test/image/mocks/parcats_hoveron_color.json +++ b/test/image/mocks/parcats_hoveron_color.json @@ -3,7 +3,7 @@ {"type": "parcats", "domain": {"x": [0.125, 0.625],"y": [0.25, 0.75]}, "hoveron": "color", - "hoverinfo": "probability", + "hoverinfo": "count+probability", "dimensions":[ {"label": "One", "values": [1, 1, 2, 1, 2, 1, 1, 2, 1]}, {"label": "Two", "values": ["A", "B", "A", "B", "C", "C", "A", "B", "C"]}, From 003124fc60611b8ce48137f311e1c5a2282a6d5a Mon Sep 17 00:00:00 2001 From: Wei-Wei Chi Date: Wed, 27 Mar 2024 16:30:58 -0400 Subject: [PATCH 3/5] draftlogs 6944 --- draftlogs/6944_change.md | 1 + 1 file changed, 1 insertion(+) create mode 100644 draftlogs/6944_change.md diff --git a/draftlogs/6944_change.md b/draftlogs/6944_change.md new file mode 100644 index 00000000000..e4f5891ccfc --- /dev/null +++ b/draftlogs/6944_change.md @@ -0,0 +1 @@ +- Update hover count info label from `totalCount` to `bandColorCount` in `createHoverLabelForColorHovermode`[[#6944](https://github.com/plotly/plotly.js/pull/6944)] \ No newline at end of file From 81fda6fc1f8e6b378bd0c72626e1b3cd60bfe49c Mon Sep 17 00:00:00 2001 From: Wei-Wei Chi Date: Wed, 27 Mar 2024 16:30:58 -0400 Subject: [PATCH 4/5] draftlogs 6944 --- draftlogs/6944_change.md | 1 + 1 file changed, 1 insertion(+) create mode 100644 draftlogs/6944_change.md diff --git a/draftlogs/6944_change.md b/draftlogs/6944_change.md new file mode 100644 index 00000000000..9362f9f74c5 --- /dev/null +++ b/draftlogs/6944_change.md @@ -0,0 +1 @@ +- Fix hover count info label in `createHoverLabelForColorHovermode`[[#6944](https://github.com/plotly/plotly.js/pull/6944)] \ No newline at end of file From e50cc7ac51e95b26f915834463f8153455004dbd Mon Sep 17 00:00:00 2001 From: Mojtaba Samimi <33888540+archmoj@users.noreply.github.com> Date: Thu, 28 Mar 2024 12:14:53 -0400 Subject: [PATCH 5/5] Update draftlogs/6944_change.md --- draftlogs/6944_change.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/draftlogs/6944_change.md b/draftlogs/6944_change.md index 9505029f2fd..21890229b0f 100644 --- a/draftlogs/6944_change.md +++ b/draftlogs/6944_change.md @@ -1,3 +1,3 @@ -- Fix hover count info label in `createHoverLabelForColorHovermode`[[#6944](https://github.com/plotly/plotly.js/pull/6944)] - +- Fix hover count in parcats trace [[#6944](https://github.com/plotly/plotly.js/pull/6944)], + with thanks to @weiweikee for the contribution!