refactor: rename getNodeType to getAnimatedType (and move it to packages/animated)

Author: aleclarson

packages/animated/src/getAnimatedType.ts

@@ -0,0 +1,18 @@
+import { is, isAnimatedString } from 'shared'
+import { AnimatedType } from './types'
+import { AnimatedArray } from './AnimatedArray'
+import { AnimatedString } from './AnimatedString'
+import { AnimatedValue } from './AnimatedValue'
+import { getAnimated } from './Animated'
+
+/** Return the `Animated` node constructor for a given value */
+export function getAnimatedType(value: any): AnimatedType {
+  const parentNode = getAnimated(value)
+  return parentNode
+    ? (parentNode.constructor as any)
+    : is.arr(value)
+    ? AnimatedArray
+    : isAnimatedString(value)
+    ? AnimatedString
+    : AnimatedValue
+}

packages/animated/src/index.ts

@@ -4,5 +4,6 @@ export * from './AnimatedString'
 export * from './AnimatedArray'
 export * from './AnimatedObject'
 export * from './AnimatedProps'
+export * from './getAnimatedType'
 export * from './createHost'
 export * from './types'

packages/core/src/Interpolation.ts

@@ -13,14 +13,7 @@ import {
 import * as G from 'shared/globals'
 
 import { FrameValue, isFrameValue } from './FrameValue'
-import {
-  getAnimated,
-  setAnimated,
-  AnimatedValue,
-  AnimatedArray,
-  AnimatedType,
-  getPayload,
-} from 'animated'
+import { getAnimated, setAnimated, getAnimatedType, getPayload } from 'animated'
 
 /**
  * An `Interpolation` is a memoized value that's computed whenever one of its
@@ -49,7 +42,7 @@ export class Interpolation<In = any, Out = any> extends FrameValue<Out> {
     this.calc = createInterpolator(...args)
 
     const value = this._get()
-    const nodeType: AnimatedType = is.arr(value) ? AnimatedArray : AnimatedValue
+    const nodeType = getAnimatedType(value)
 
     // Assume the computed value never changes type.
     setAnimated(this, nodeType.create(value))

packages/core/src/SpringValue.ts

@@ -20,6 +20,7 @@ import {
   getAnimated,
   setAnimated,
   Animated,
+  getAnimatedType,
 } from 'animated'
 import * as G from 'shared/globals'
 
@@ -490,7 +491,7 @@ export class SpringValue<T = any> extends FrameValue<T> {
   protected _updateNode(value: any): Animated | undefined {
     let node = getAnimated(this)
     if (!is.und(value)) {
-      const nodeType = getNodeType(value)
+      const nodeType = getAnimatedType(value)
       if (!node || node.constructor !== nodeType) {
         setAnimated(this, (node = nodeType.create(value)))
       }
@@ -680,7 +681,7 @@ export class SpringValue<T = any> extends FrameValue<T> {
       if (immediate) {
         node = this._updateNode(goal)!
       } else {
-        const nodeType = getNodeType(to)
+        const nodeType = getAnimatedType(to)
         if (nodeType !== node.constructor) {
           throw Error(
             `Cannot animate between ${node.constructor.name} and ${nodeType.name}, as the "to" prop suggests`
@@ -940,18 +941,6 @@ export class SpringValue<T = any> extends FrameValue<T> {
   }
 }
 
-/** Return the `Animated` node constructor for a given value */
-function getNodeType(value: any): AnimatedType {
-  const parentNode = getAnimated(value)
-  return parentNode
-    ? (parentNode.constructor as any)
-    : is.arr(value)
-    ? AnimatedArray
-    : isAnimatedString(value)
-    ? AnimatedString
-    : AnimatedValue
-}
-
 /**
  * The "finished" value is determined by each "onRest" handler,
  * based on whether the current value equals the goal value that