Skip to content

TypeScript: SpringProps doesn't inherit from SpringBaseProps #386

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
bhollis opened this issue Dec 20, 2018 · 2 comments
Closed

TypeScript: SpringProps doesn't inherit from SpringBaseProps #386

bhollis opened this issue Dec 20, 2018 · 2 comments
Labels
area: typescript Typescript issues

Comments

@bhollis
Copy link
Contributor

bhollis commented Dec 20, 2018

SpringProps (which is used from Spring) doesn't inherit from SpringBaseProps, and thus doesn't include properties like native.

Code: https://github.com/react-spring/react-spring/blob/master/types/universal.d.ts#L67

@vpicone
Copy link
Contributor

vpicone commented Feb 1, 2019

Now that this is set up, components that allow spring props (Trail, Keyframes and Transition) should extend SpringProps. As it is now, these components can't use props that aren't SpringBaseProps (after, etc.). I'll open a PR for Trail since it's rather simple, not sure how the others should be handled.

Trail props don't include after

@aleclarson
Copy link
Contributor

Fixed by e622f17

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: typescript Typescript issues
Projects
None yet
Development

No branches or pull requests

3 participants