Skip to content

reset and initial props doesn't work with useTransition #436

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
b00sta opened this issue Jan 11, 2019 · 2 comments
Closed

reset and initial props doesn't work with useTransition #436

b00sta opened this issue Jan 11, 2019 · 2 comments
Labels
kind: bug Something isn't working
Milestone

Comments

@b00sta
Copy link

b00sta commented Jan 11, 2019

Seems like reset and initial props doesn't work with useTransition as expected. Try to comment out it here. I guess, bug with initial prop related to wrong initial state at this line https://github.com/react-spring/react-spring/blob/f938b667860da1ace2f13523ea7aae5a9ba2a320/src/hooks/useTransition.js#L146

@drcmda
Copy link
Member

drcmda commented Jan 11, 2019

Yep, saw this today, too, it's the reverse. I am re-writing hooks from the ground up currently, there will be a big update soon. They're all still experimental for now, but the upcoming version will make them official with docs, a proper api and all these little bugs hopefully fixed.

@aleclarson aleclarson added the type: needs repro Needs minimal reproduction label Apr 1, 2019
@aleclarson aleclarson added kind: bug Something isn't working and removed type: needs repro Needs minimal reproduction labels Apr 1, 2019
@aleclarson aleclarson reopened this Apr 1, 2019
@aleclarson aleclarson mentioned this issue Apr 16, 2019
5 tasks
@aleclarson
Copy link
Contributor

Fixed in #632 🎉

When reset is true, all items will repeat their enter transition.

The initial transition never repeats, even if reset is true.

@aleclarson aleclarson added this to the v9.0.0 milestone Apr 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind: bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants