Skip to content

Git + quarto balloons the source control pane #1374

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jthomasmock opened this issue Sep 22, 2023 · 6 comments
Closed

Git + quarto balloons the source control pane #1374

jthomasmock opened this issue Sep 22, 2023 · 6 comments
Assignees

Comments

@jthomasmock
Copy link
Contributor

jthomasmock commented Sep 22, 2023

Positron Version: Positron Version: 2023.09.0 (Universal) build 203
Code - OSS Version: 1.79.0
Commit: 519fbc7
Date: 2023-09-22T02:37:21.484Z
Electron: 22.3.10
Chromium: 108.0.5359.215
Node.js: 16.17.1
V8: 10.8.168.25-electron.0
OS: Darwin arm64 22.6.0

Steps to reproduce the issue:

  1. Render a qmd to html/revealjs without self-contained: true
  2. There's a lot of files that get added to a file-name_files output
  3. The git pane doesn't collapse these files, so it's quite messy to do commits, rather than in RStudio where this output folder is collapsed by default to allow committing the entire folder.

This is also an issue for things like virtual environments since we aren't adding default items to .gitignore - captured in: #1372

What did you expect to happen?

In RStudio where this output folder is collapsed by default to allow committing the entire folder. I'd also like to configure this in Positron, or have the files organized by folder and able to be collapsed in the UI.

Were there any error messages in the output or Developer Tools console?

@juliasilge
Copy link
Contributor

I have noticed this too, and specifically want to note how overwhelming it feels when this happens relative to the RStudio behavior, for what are quite common use cases. The other time I have noticed it is when running reverse dependency checks for a package. You get a fairly scary looking message as well.

I believe we haven't touched the vscode "Source Control" support at all, so making changes relative to vscode would be a significant step.

@jennybc
Copy link
Member

jennybc commented Sep 25, 2023

Screen.Recording.2023-09-25.at.1.35.23.PM.mov

You can toggle to a tree view, which then lets you stage a folder for example. This is true in VS Code and, therefore, in Positron.

@jthomasmock
Copy link
Contributor Author

Thanks Jenny - this has significantly reduced my anxiety around the MANY small files problem 😄

Like most things, this is apparently configurable as a default:

image

I might suggest that we set tree as the default, given the likelihood of virtual environments, quarto output, etc creating many small files?

@juliasilge
Copy link
Contributor

I just set this to "Ready for Review" but it's certainly possible we could do other work to better handle the experience of many, many changes in git.

@jthomasmock
Copy link
Contributor Author

Your fix is definitely appreciated!

@DavisVaughan
Copy link
Contributor

I am confirming that we default to "tree" view now, and am going to close on account of the fact that it typically feels a little better this way. If we encounter more pain in the future we can open another issue for sure!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants