You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The rest of Positron uses React 18, but the dataviewer extension uses React 17. Ideally, it would be nice to have the dataviewer using the same React as the rest of the application (the dataviewer is an extension, so it has its own package.json file).
React Query also had a major update to v5 recently. This introduces some breaking changes to the API, but includes helpful bug fixes and performance improvements, and our current implementation of React Query is buggy and in need of refactoring anyway. From the docs:
v5 is currently available as a release-candidate. We don't anticipate any major API changes from here on out. We encourage you to try it out and report any issues you find.
Also react query appears to require react 18, so these 2 upgrades are closely related
The text was updated successfully, but these errors were encountered:
We are currently blocked on the upgrade to V5 of React Query. We also are blocked on the React 18 upgrade as well
V5 removed the umd directory from the builds, and converted the module type from common JS module to ES module. This isn't a problem for production mode where we use a bundler, but in development mode, we don't have a bundler and so we have some hacks for reading in the local source files created when we build. We can't do this with react query v5, and if any other tanstack libraries do a similar change, we won't be able to upgrade them either.
I think we will ultimately have to solve this by having a bundler run in watch mode for development purposes
If there are API changes that are compatible with both v4 and v5, we can make some of those ahead of time to ease the pain of an eventual v5 upgrade if and when we do sort this out.
This change is more about building Positron than any specific user behavior, but I can confirm that as of build 1453 the viewer still works as expected:
Uh oh!
There was an error while loading. Please reload this page.
The rest of Positron uses React 18, but the dataviewer extension uses React 17. Ideally, it would be nice to have the dataviewer using the same React as the rest of the application (the dataviewer is an extension, so it has its own package.json file).
React Query also had a major update to v5 recently. This introduces some breaking changes to the API, but includes helpful bug fixes and performance improvements, and our current implementation of React Query is buggy and in need of refactoring anyway. From the docs:
Also react query appears to require react 18, so these 2 upgrades are closely related
The text was updated successfully, but these errors were encountered: