Skip to content

Relax engine requirements #59

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
lee-reinhardt opened this issue Dec 17, 2019 · 3 comments
Closed

Relax engine requirements #59

lee-reinhardt opened this issue Dec 17, 2019 · 3 comments

Comments

@lee-reinhardt
Copy link

The latest version 3.0.0 looks great, and thank you for all the improvements.

However, one thing that changed is the engines definition in package.json. When attempting to install with yarn, it refuses to install if you're not using node 12.

This can be worked around with the --ignore-engines flag, but it's not clear whether requiring v12 is absolutely necessary. I think at least v10 should be allowed as well.

$ yarn add react-diff-viewer
yarn add v1.21.1
[1/4] 🔍  Resolving packages...
[2/4] 🚚  Fetching packages...
error [email protected]: The engine "node" is incompatible with this module. Expected version "^12". Got "10.17.0"
error Found incompatible module.
@praneshr
Copy link
Owner

@lee-reinhardt Thanks for pointing this out. I’ll release a patch ASAP. Till then please use —ignore-engines

@praneshr
Copy link
Owner

Fixed in v3.0.1

@simmerer
Copy link

Just experienced this issue with 3.0.1, sadly:

$ yarn add react-diff-viewer
yarn add v1.21.1
[1/4] 🔍  Resolving packages...
[2/4] 🚚  Fetching packages...
error [email protected]: The engine "node" is incompatible with this module. Expected version "^12 || ^10 || ^8". Got "13.6.0"
error Found incompatible module.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants