Fix test

Author: JoviDeCroock

hooks/src/index.js

@@ -159,32 +159,6 @@ function getHookState(index, type) {
 	return hooks._list[index];
 }
 
-options._afterRender = (newVNode, oldVNode) => {
-	if (newVNode._component && newVNode._component.__hooks) {
-		const hooks = newVNode._component.__hooks._list;
-		const stateHooksThatExecuted = hooks.filter(
-			/** @type {(x: import('./internal').HookState) => x is import('./internal').ReducerHookState} */
-			// @ts-expect-error
-			x => x._component && x._didExecute
-		);
-
-		if (
-			stateHooksThatExecuted.length &&
-			!stateHooksThatExecuted.some(x => x._didUpdate) &&
-			oldVNode.props === newVNode.props
-		) {
-			newVNode._component.__hooks._pendingEffects = [];
-			newVNode._flags |= SKIP_CHILDREN;
-		}
-
-		stateHooksThatExecuted.some(hook => {
-			hook._didExecute = hook._didUpdate = false;
-		});
-	}
-
-	if (oldAfterRender) oldAfterRender(newVNode, oldVNode);
-};
-
 /**
  * @template {unknown} S
  * @param {import('./index').Dispatch<import('./index').StateUpdater<S>>} [initialState]

hooks/test/browser/useState.test.js

@@ -1,6 +1,6 @@
 import { setupRerender, act } from 'preact/test-utils';
 import { createElement, render, createContext, Component } from 'preact';
-import { vi } from 'vitest';
+import { afterAll, beforeAll, expect, vi } from 'vitest';
 import {
 	useState,
 	useContext,
@@ -380,7 +380,7 @@ describe('useState', () => {
 		expect(scratch.innerHTML).to.equal('<p>hello world!!!</p>');
 	});
 
-	it('should limit rerenders when setting state to NaN', () => {
+	it('should exhaust renders when NaN state is set as a result of a props update', () => {
 		const calls = [];
 		const App = ({ i }) => {
 			calls.push('rendering' + i);
@@ -402,10 +402,57 @@ describe('useState', () => {
 		act(() => {
 			render(<App i={2} />, scratch);
 		});
-		expect(calls.length).to.equal(3);
+		expect(calls.length).to.equal(27);
 		expect(calls.slice(1).every(c => c === 'rendering2')).to.equal(true);
 	});
 
+	it('should bail correctly when setting NaN twice', () => {
+		const calls = [];
+		let set;
+		const Greeting = ({ greeting }) => {
+			calls.push('rendering ' + greeting);
+			return <p>{greeting}</p>;
+		};
+		const App = () => {
+			const [greeting, setGreeting] = useState(0);
+			set = setGreeting;
+
+			return <Greeting greeting={greeting} />;
+		};
+
+		act(() => {
+			render(<App />, scratch);
+		});
+		expect(calls.length).to.equal(1);
+		expect(calls).to.deep.equal(['rendering 0']);
+
+		act(() => {
+			set(1);
+		});
+		expect(calls.length).to.equal(2);
+		expect(calls).to.deep.equal(['rendering 0', 'rendering 1']);
+
+		act(() => {
+			set(NaN);
+		});
+		expect(calls.length).to.equal(3);
+		expect(calls).to.deep.equal([
+			'rendering 0',
+			'rendering 1',
+			'rendering NaN'
+		]);
+
+		act(() => {
+			set(NaN);
+		});
+		expect(calls.length).to.equal(3);
+		expect(calls).to.deep.equal([
+			'rendering 0',
+			'rendering 1',
+			'rendering NaN'
+		]);
+	});
+
 	describe('Global sCU', () => {
 		let prevScu;
 		beforeAll(() => {