Skip to content

Make PricingOptions' "Whats included" title customizable #978

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 8 commits into
base: main
Choose a base branch
from
Draft

Make PricingOptions' "Whats included" title customizable #978

wants to merge 8 commits into from

Conversation

danielguillan
Copy link
Contributor

@danielguillan danielguillan commented Apr 15, 2025 •
edited
Loading

Summary

Adds a new PricingOptions.FeatureListTitle component that enables customization of the feature list title in the PricingOptions component. Resolves #970

List of notable changes:

  • Added a new PricingOptions.FeatureListTitle component

Steps to test:

Supporting resources (related issues, external links, etc):

Contributor checklist:

  • All new and existing CI checks pass
  • Tests prove that the feature works and covers both happy and unhappy paths
  • Any drop in coverage, breaking changes or regressions have been documented above
  • UI Changes contain new visual snapshots (generated by adding update snapshots label to the PR)
  • All developer debugging and non-functional logging has been removed
  • Related issues have been referenced in the PR description

Reviewer checklist:

  • Check that pull request and proposed changes adhere to our contribution guidelines and code of conduct
  • Check that tests prove the feature works and covers both happy and unhappy paths
  • Check that there aren't other open Pull Requests for the same update/change

Screenshots:

image

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Apr 15, 2025 •
edited
Loading

🦋 Changeset detected

Latest commit: f2fc48b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 7 packages
Name Type
@primer/react-brand Patch
@primer/brand-docs Patch
@primer/brand-primitives Patch
@primer/brand-e2e Patch
@primer/brand-fonts Patch
@primer/brand-config Patch
@primer/brand-storybook Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 15, 2025 •
edited
Loading

🟢 No design token changes found

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 15, 2025 •
edited
Loading

🟢 No visual differences found

Our visual comparison tests did not find any differences in the UI.

@danielguillan danielguillan requested review from rezrah and joshfarrant and removed request for rezrah April 15, 2025 12:59
joshfarrant
joshfarrant approved these changes Apr 15, 2025
View reviewed changes
Copy link
Contributor

@joshfarrant joshfarrant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

rezrah
rezrah reviewed Apr 15, 2025
View reviewed changes
packages/react/src/PricingOptions/PricingOptions.tsx
@@ -45,6 +45,7 @@ const testIds = {
primaryAction: 'PricingOptions__primaryAction',
secondaryAction: 'PricingOptions__secondaryAction',
featureList: 'PricingOptions__featureList',
featureListTitle: 'PricingOptions__featureListTitle',
Copy link
Collaborator

@rezrah rezrah Apr 15, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@danielguillan could we call this featureListGroupHeading (or something similar)? Ideally it would be featureListHeading but that's already used. Title and heading are interchangeable terms so we should pick one. For consistency I'd prefer latter. What do you think?

@danielguillan danielguillan marked this pull request as draft April 23, 2025 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rezrah rezrah rezrah left review comments

@joshfarrant joshfarrant joshfarrant approved these changes

Copilot code review Copilot Awaiting requested review from Copilot Copilot will automatically review once the pull request is marked ready for review

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[PricingOptions]: Expose "What's included" toggle text as prop
3 participants
@danielguillan @joshfarrant @rezrah