Remove "Find Next" and "Find Previous" from Nav dropdown

[simranaggarwal1999]

Nature of issue?

• 👍 Found a bug
• 👍 Existing feature enhancement
• New feature request

Details about the bug:

• Web browser and version: FireFox

• Operating System: Windows

• Steps to reproduce this bug:

1. Click Edit in navbar
2. Click Find Next.
3. Click anywhere on the dialog box that pops up other than the text box.
4. The dialog box closes.

Feature enhancement details:
I feel the dialog box should not close this way. Also there should be a find button that would start finding in the document according to the letters typed by the user.

[welcome]

Welcome! 👋 Thanks for opening your first issue here! And to ensure the community is able to respond to your issue, be sure to follow the issue template if you haven't already.

[ashu8912]

@simranaggarwal1999 Yes The Find-Next Modal Should Close Only when The close button is clicked.will have to ask @catarak whether she wants this change,if yes will send a pr that fixes this.

[catarak]

Find next should maybe just open the find dialog? The overall find UX is a little off and should be adjusted to work like other text editors (i.e. VSCode).

Related to #942.

[simranaggarwal1999]

@catarak I feel Find Next dialog box should find and select the next occurrence of the text specified in the Find dialog box and Find Previous dialog box should find and select the previous occurrence of the text specified in the Find dialog box. Kindly guide me to solve this issue.

[ashu8912]

This is a issue with codemirror the find Next and find Prev both doesn't show the desired behaviour or a behaviour that is not similar to what we expect with editors like vscode when we press these combinations.
I have raised a issue regarding this on the codeMirror repo lets see if they add this feature.
codemirror/codemirror5#6130

[ashu8912]

So The CodeMirror editor doesn't currently supports the behaviour we are thinking of achieving here.

[ashu8912]

@catarak what should we do now with the design should we let it the same for now.

[catarak]

I think that Find Next and Find Previous should just be removed from the dropdown because it's confusing. The keyboard shortcut overlay lists those shortcuts anyway.

[satyasaibhushan]

Hey @catarak !
I'd like to work on this issue if you simply need to remove the options from the dropdown

[satyasaibhushan]

But, there clearly seems to be a focus issue with the find next and find previous features as sometimes they just go off when clicked on the left part (on the play button or the editor) and they freeze and don't close when clicked on the right part of the screen(on the preview section), which leaves us no option but to refresh the page.
Please look into this!!

[catarak]

@satyasaibhushan you can go ahead and work on this one!

also, would you mind putting the other issue you're reporting in a separate issue, with steps to reproduce?

[satyasaibhushan]

Hey @catarak,
I hope this closes the issue. Please check if I did anything wrong.
And I will open another issue as you mentioned :)