Skip to content

German translation of the web-editor #1783

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
tlsaeger opened this issue Mar 1, 2021 · 11 comments · Fixed by #1869
Closed

German translation of the web-editor #1783

tlsaeger opened this issue Mar 1, 2021 · 11 comments · Fixed by #1869

Comments

@tlsaeger
Copy link
Contributor

tlsaeger commented Mar 1, 2021

Nature of issue?

  • Existing feature enhancement

Feature enhancement details:

Hi there,
I could contribute a german translation of the p5-web UI, if you like?
I was not sure if this is maybe already in the making, so thats why I'm not starting right away.
Cheers
Tom

@welcome
Copy link

welcome bot commented Mar 1, 2021

Welcome! 👋 Thanks for opening your first issue here! And to ensure the community is able to respond to your issue, be sure to follow the issue template if you haven't already.

@catarak
Copy link
Member

catarak commented Mar 9, 2021

Hi @tlsaeger! There isn't a German translation and it would be great to have one. Take a look at the translation documentation to get started!

@tlsaeger
Copy link
Contributor Author

tlsaeger commented Mar 11, 2021

Hi @catarak thank you! Unfortunately I cannot get the dropdown to show. I've followed the installation guide as well as the translation documentation. I added TRANSLATIONS_ENABLED=true to .env but it still does not show up. Everything else is running perfectly.
Thanks for your help!

@catarak
Copy link
Member

catarak commented Mar 12, 2021

@tlsaeger that's super strange! Can you open the browser console and see if you notice anything? If the app is working okay, one thing is that it could be a typo in .env.

@tlsaeger
Copy link
Contributor Author

@catarak Ran the program to check if something is in the console. Did not change anything, now it works. Thanks for your help!

@catarak
Copy link
Member

catarak commented Mar 18, 2021

@tlsaeger glad you figured it out! my guess is that you had added the variable to .env but you hadn't restarted the server, as of right now the server doesn't get automatically restarted for .env changes (and maybe it should!)

@tlsaeger
Copy link
Contributor Author

@catarak I sent a PR. Thanks again for your support.

@binomial0
Copy link

I looked over the translation in the PR (@tlsaeger asked for this) and wrote some suggestions. I'll link them here; I hope the format is ok and that this is useful. https://gist.github.com/binomial0/29b78bdaf81ff4399c36edced2ea30ad

@tlsaeger
Copy link
Contributor Author

To add a little context I asked if someone would help me with proof reading here: Twitter and in the processing forum.
@binomial0 was so kind to offer first suggestions which i will add in the coming days.

@tlsaeger
Copy link
Contributor Author

I incorporated the changes suggested by @binomial0 thanks again for your support. @catarak from my side the PR is ready to be merged.

@catarak
Copy link
Member

catarak commented Jun 11, 2021

@tlsaeger great, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants