Skip to content

Commit 034e388

Browse files
author
Lauren McCarthy
committed
remove translate and rotate for elt issue #1200
1 parent 2bf3040 commit 034e388

File tree

1 file changed

+63
-63
lines changed

1 file changed

+63
-63
lines changed

lib/addons/p5.dom.js

Lines changed: 63 additions & 63 deletions
Original file line numberDiff line numberDiff line change
@@ -54,7 +54,7 @@
5454
* function setup() {
5555
* createCanvas(100,100);
5656
* //translates canvas 50px down
57-
* select('canvas').translate(0,50);
57+
* select('canvas').position(100, 100);
5858
* }
5959
* </code></div>
6060
* <div ><code class='norender'>
@@ -1160,25 +1160,25 @@
11601160
}
11611161
};
11621162

1163-
/**
1164-
* Translates an element with css transforms in either 2d (if 2 arguments given)
1165-
* or 3d (if 3 arguments given) space.
1166-
* @method translate
1167-
* @param {Number} x x-position in px
1168-
* @param {Number} y y-position in px
1169-
* @param {Number} [z] z-position in px
1170-
* @param {Number} [perspective] sets the perspective of the parent element in px,
1171-
* default value set to 1000px
1172-
* @return {Object/p5.Element}
1173-
* @example
1174-
* <div ><code class='norender'>
1175-
* function setup() {
1176-
* var cnv = createCanvas(100,100);
1177-
* //translates canvas 50px down
1178-
* cnv.translate(0,50);
1179-
* }
1180-
* </code></div>
1181-
*/
1163+
// *
1164+
// * Translates an element with css transforms in either 2d (if 2 arguments given)
1165+
// * or 3d (if 3 arguments given) space.
1166+
// * @method translate
1167+
// * @param {Number} x x-position in px
1168+
// * @param {Number} y y-position in px
1169+
// * @param {Number} [z] z-position in px
1170+
// * @param {Number} [perspective] sets the perspective of the parent element in px,
1171+
// * default value set to 1000px
1172+
// * @return {Object/p5.Element}
1173+
// * @example
1174+
// * <div ><code class='norender'>
1175+
// * function setup() {
1176+
// * var cnv = createCanvas(100,100);
1177+
// * //translates canvas 50px down
1178+
// * cnv.translate(0,50);
1179+
// * }
1180+
// * </code></div>
1181+
11821182
// p5.Element.prototype.translate = function(){
11831183
// this.elt.style.position = 'absolute';
11841184
// // save out initial non-translate transform styling
@@ -1202,50 +1202,50 @@
12021202
// return this;
12031203
// };
12041204

1205-
/**
1206-
* Rotates an element with css transforms in either 2d (if 2 arguments given)
1207-
* or 3d (if 3 arguments given) space.
1208-
* @method rotate
1209-
* @param {Number} x amount of degrees to rotate the element along the x-axis in deg
1210-
* @param {Number} [y] amount of degrees to rotate the element along the y-axis in deg
1211-
* @param {Number} [z] amount of degrees to rotate the element along the z-axis in deg
1212-
* @return {Object/p5.Element}
1213-
* @example
1214-
* <div><code>
1215-
* var x = 0,
1216-
* y = 0,
1217-
* z = 0;
1218-
*
1219-
* function draw(){
1220-
* x+=.5 % 360;
1221-
* y+=.5 % 360;
1222-
* z+=.5 % 360;
1223-
* //rotates p5.js logo .5 degrees on every axis each frame.
1224-
* select('canvas').rotate(x,y,z);
1225-
* }
1226-
* </code></div>
1227-
*/
1228-
p5.Element.prototype.rotate = function(){
1229-
// save out initial non-rotate transform styling
1230-
var transform = '';
1231-
if (this.elt.style.transform) {
1232-
var transform = this.elt.style.transform.replace(/rotate3d\(.*\)/g, '');
1233-
transform = transform.replace(/rotate[X-Z]?\(.*\)/g, '');
1234-
}
1205+
// *
1206+
// * Rotates an element with css transforms in either 2d (if 2 arguments given)
1207+
// * or 3d (if 3 arguments given) space.
1208+
// * @method rotate
1209+
// * @param {Number} x amount of degrees to rotate the element along the x-axis in deg
1210+
// * @param {Number} [y] amount of degrees to rotate the element along the y-axis in deg
1211+
// * @param {Number} [z] amount of degrees to rotate the element along the z-axis in deg
1212+
// * @return {Object/p5.Element}
1213+
// * @example
1214+
// * <div><code>
1215+
// * var x = 0,
1216+
// * y = 0,
1217+
// * z = 0;
1218+
// *
1219+
// * function draw(){
1220+
// * x+=.5 % 360;
1221+
// * y+=.5 % 360;
1222+
// * z+=.5 % 360;
1223+
// * //rotates p5.js logo .5 degrees on every axis each frame.
1224+
// * select('canvas').rotate(x,y,z);
1225+
// * }
1226+
// * </code></div>
1227+
1228+
// p5.Element.prototype.rotate = function(){
1229+
// // save out initial non-rotate transform styling
1230+
// var transform = '';
1231+
// if (this.elt.style.transform) {
1232+
// var transform = this.elt.style.transform.replace(/rotate3d\(.*\)/g, '');
1233+
// transform = transform.replace(/rotate[X-Z]?\(.*\)/g, '');
1234+
// }
12351235

1236-
if (arguments.length === 1){
1237-
this.elt.style.transform = 'rotate('+arguments[0]+'deg)';
1238-
}else if (arguments.length === 2){
1239-
this.elt.style.transform = 'rotate('+arguments[0]+'deg, '+arguments[1]+'deg)';
1240-
}else if (arguments.length === 3){
1241-
this.elt.style.transform = 'rotateX('+arguments[0]+'deg)';
1242-
this.elt.style.transform += 'rotateY('+arguments[1]+'deg)';
1243-
this.elt.style.transform += 'rotateZ('+arguments[2]+'deg)';
1244-
}
1245-
// add remaining transform back on
1246-
this.elt.style.transform += transform;
1247-
return this;
1248-
};
1236+
// if (arguments.length === 1){
1237+
// this.elt.style.transform = 'rotate('+arguments[0]+'deg)';
1238+
// }else if (arguments.length === 2){
1239+
// this.elt.style.transform = 'rotate('+arguments[0]+'deg, '+arguments[1]+'deg)';
1240+
// }else if (arguments.length === 3){
1241+
// this.elt.style.transform = 'rotateX('+arguments[0]+'deg)';
1242+
// this.elt.style.transform += 'rotateY('+arguments[1]+'deg)';
1243+
// this.elt.style.transform += 'rotateZ('+arguments[2]+'deg)';
1244+
// }
1245+
// // add remaining transform back on
1246+
// this.elt.style.transform += transform;
1247+
// return this;
1248+
// };
12491249

12501250
/**
12511251
* Sets the given style (css) property (1st arg) of the element with the

0 commit comments

Comments
 (0)