Skip to content

Dom.createImg() should allow passing an onload callback. #578

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
brysonian opened this issue Mar 20, 2015 · 4 comments
Closed

Dom.createImg() should allow passing an onload callback. #578

brysonian opened this issue Mar 20, 2015 · 4 comments

Comments

@brysonian
Copy link
Contributor

I suppose it could be 2nd or 3rd arg. If 2nd is string it is alt attr, if it is a function, onload callback.

@shiffman
Copy link
Member

Agreed! Just chiming in to cross-reference this with #561 in case that's relevant to the discussion.

@lmccart
Copy link
Member

lmccart commented Jul 7, 2015

@futuremarc this seems related to some of the callback stuff we were looking at during the meetup last month, want to take a look if you have time?

@futuremarc
Copy link
Contributor

createImg() actually does take a callback now via PR #745

@lmccart
Copy link
Member

lmccart commented Jul 7, 2015

oops, missed that, great!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants