Skip to content

Feature: Language Server Protocol, Reference Support #684

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
processing-bot opened this issue Mar 5, 2023 · 4 comments
Closed

Feature: Language Server Protocol, Reference Support #684

processing-bot opened this issue Mar 5, 2023 · 4 comments

Comments

@processing-bot
Copy link
Collaborator

Created by: Efratror

Description

Add a feature for supporting references to the LS

Expected Behavior

References are supported by the PDE (find usage). So it would be nice to have it for the server as well

Current Behavior

Only finding declarations is supported at the moment

Your Environment

Possible Causes / Solutions

  • Add static function "searchReference" to the "pdeSymbolFinder" class
  • Use it to find all references using the AST,
  • Send (found) references back to the LS-client

I'm willing to implement this, please assignee me if you're ok with this idea.

@processing-bot
Copy link
Collaborator Author

Created by: benfry

Yes please, thanks!

@processing-bot
Copy link
Collaborator Author

Created by: Efratror

@benfry could you please explain what I missed in my previous pr regarding the style sheet? I had read it before placing the pr but clearly I misunderstood some parts of it.

Thanks in advance

@processing-bot
Copy link
Collaborator Author

Created by: benfry

The main one was things like

if(optionalJavaOffset.isEmpty()){

which should read

if (optionalJavaOffset.isEmpty()) {

but I'd have to check if there were others. Perhaps it wasn't much?

@processing-bot
Copy link
Collaborator Author

Created by: Efratror

aha thanks, i will try doing better for this PR😊

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant