Skip to content

Commit 7dd92d7

Browse files
committed
Review comments: unnecessary function call
Review changes: removal of uneccesary deletion
1 parent 60861f8 commit 7dd92d7

File tree

1 file changed

+9
-7
lines changed

1 file changed

+9
-7
lines changed

Makefile

Lines changed: 9 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -422,24 +422,26 @@ kueue-setup:
422422
bash scripts/setup-kueue-resources.sh
423423
# RHOAI/ODH related resources installation
424424

425+
# Basic Usage
426+
# all-in-one will create all resources necessary to create GPU enabled ML workloads via OpenShift AI
427+
# Users have the choice between installing RHOAI and ODH
428+
# For RHOAI use `make all-in-one` and to remove all of the operators run `make delete-all-in-one`
429+
# For ODH use `make all-in-one -e USE_RHOAI=false` and to remove all of the operators run `make delete-all-in-one -e USE_RHOAI=false`
430+
425431
##@ all-in-one
426432
.PHONY: all-in-one
427433
all-in-one:
428434
@echo -e "\n ==> Installing Everything needed for distributed AI platform on OpenShift cluster \n"
429-
-make delete-nfd-operator
430-
-make delete-ai-platform-operator
431-
-make delete-nvidia-operator
432435
-make install-nfd-operator
433436
-make install-ai-platform-operator
434437
-make install-nvidia-operator
435438

436439
.PHONY: delete-all-in-one
437440
delete-all-in-one:
438441
@echo -e "\n ==> Removing Everything needed for distributed AI platform on OpenShift cluster \n"
439-
-make delete-rhoai
440442
-make delete-nfd-operator
441-
-make delete-nvidia-operator
442443
-make delete-ai-platform-operator
444+
-make delete-nvidia-operator
443445

444446
##@ general
445447
.PHONY: delete-ai-platform-operator
@@ -460,15 +462,15 @@ endif
460462

461463
.PHONY: delete-rhoai-operator
462464
delete-rhoai-operator: ## Delete RHOAI Operator
463-
@echo -e "\n==> Deleting OpenShift AI Operator \n"
465+
@echo -e "\n ==> Deleting OpenShift AI Operator \n"
464466
-kubectl delete subscription rhods-operator -n redhat-ods-operator
465467
-export CLUSTER_SERVICE_VERSION=`kubectl get clusterserviceversion -n redhat-ods-operator -l operators.coreos.com/rhods-operator.redhat-ods-operator -o custom-columns=:metadata.name`; \
466468
kubectl delete clusterserviceversion $$CLUSTER_SERVICE_VERSION -n redhat-ods-operator
467469
kubectl delete namespace redhat-ods-operator
468470

469471
.PHONY: install-rhoai-operator
470472
install-rhoai-operator: ## Install RHOAI Operator
471-
@echo -e "\n==> Installing OpenShift AI Operator \n"
473+
@echo -e "\n ==> Installing OpenShift AI Operator \n"
472474
-kubectl create ns redhat-ods-operator
473475
kubectl create -f contrib/configuration/rhoai/rhoai-operator-subscription.yaml
474476
@echo Waiting for rhoai-operator Subscription to be ready

0 commit comments

Comments
 (0)