add: update machinepool tests to identify machines based on label

Author: VanillaSpoon

test/e2e/instascale_machinepool_test.go

@@ -50,9 +50,9 @@ func TestInstascaleMachinePool(t *testing.T) {
 	defer connection.Close()
 
 	// check existing cluster machine pool resources
-	// look for machine pool with aw name - expect not to find it
+	// look for a machine pool with a label key equal to aw name - expect NOT to find it
 	test.Expect(GetMachinePools(test, connection)).
-		ShouldNot(ContainElement(WithTransform(MachinePoolId, Equal("test-instascale-g4dn-xlarge"))))
+		ShouldNot(ContainElement(WithTransform(MachinePoolLabels, HaveKey("test-instascale"))))
 
 	// Setup batch job and AppWrapper
 	aw := instaScaleJobAppWrapper(test, namespace, cm)
@@ -66,15 +66,15 @@ func TestInstascaleMachinePool(t *testing.T) {
 	test.Eventually(AppWrapper(test, namespace, aw.Name), TestTimeoutGpuProvisioning).
 		Should(WithTransform(AppWrapperState, Equal(mcadv1beta1.AppWrapperStateActive)))
 
-	// look for machine pool with aw name - expect to find it
+	// look for a machine pool with a label key equal to aw name - expect to find it
 	test.Eventually(MachinePools(test, connection), TestTimeoutLong).
-		Should(ContainElement(WithTransform(MachinePoolId, Equal("test-instascale-g4dn-xlarge"))))
+		Should(ContainElement(WithTransform(MachinePoolLabels, HaveKey("test-instascale"))))
 
 	test.Eventually(AppWrapper(test, namespace, aw.Name), TestTimeoutShort).
 		Should(WithTransform(AppWrapperState, Equal(mcadv1beta1.AppWrapperStateCompleted)))
 
-	// look for machine pool with aw name - expect not to find it
+	// look for a machine pool with a label key equal to aw name - expect NOT to find it
 	test.Eventually(MachinePools(test, connection), TestTimeoutLong).
-		ShouldNot(ContainElement(WithTransform(MachinePoolId, Equal("test-instascale-g4dn-xlarge"))))
+		ShouldNot(ContainElement(WithTransform(MachinePoolLabels, HaveKey("test-instascale"))))
 
 }