Skip to content

Add Custom Image Support for MCAD in the CodeFlare Operator #114

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
jbusche opened this issue May 30, 2023 · 2 comments · Fixed by #149
Closed

Add Custom Image Support for MCAD in the CodeFlare Operator #114

jbusche opened this issue May 30, 2023 · 2 comments · Fixed by #149
Assignees
@astefanutti

Comments

@jbusche
Copy link
Collaborator

jbusche commented May 30, 2023

The ability to update or revert the MCAD image in the MCAD CR will be very helpful going forward.
@jbusche jbusche self-assigned this May 30, 2023
@anishasthana
Copy link
Contributor

We would want to update the operator, api, and crd: https://github.com/project-codeflare/codeflare-operator/blob/main/api/v1alpha1/mcad_types.go

@carsonmh carsonmh self-assigned this May 30, 2023
@carsonmh carsonmh assigned carsonmh and unassigned carsonmh May 31, 2023
@astefanutti
Copy link
Contributor

@carsonmh if you plan to work on that, there is #120 that covers the InstaScale controller, and that could be re-used for the MCAD controller, so the approach is consistent.

@astefanutti astefanutti mentioned this issue Jun 14, 2023
Merged
@carsonmh carsonmh removed their assignment Jun 14, 2023
@astefanutti astefanutti self-assigned this Jun 20, 2023
@astefanutti astefanutti moved this from Todo to In Progress in Project CodeFlare Sprint Board Jun 23, 2023
@astefanutti astefanutti mentioned this issue Jun 23, 2023
Merged
@astefanutti astefanutti moved this from In Progress to Ready For Review in Project CodeFlare Sprint Board Jun 23, 2023
@github-project-automation github-project-automation bot moved this from Ready For Review to Done in Project CodeFlare Sprint Board Jun 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@astefanutti astefanutti

Labels
None yet
Projects
Project CodeFlare Sprint Board
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(api): Support custom MCAD container image
4 participants
@astefanutti @anishasthana @carsonmh @jbusche