Skip to content

Adjust the operator kubebuilder mcad roles for quota trees PR #187

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
jbusche opened this issue Jul 19, 2023 · 2 comments · Fixed by #283
Closed

Adjust the operator kubebuilder mcad roles for quota trees PR #187

jbusche opened this issue Jul 19, 2023 · 2 comments · Fixed by #283
Assignees
@jbusche

Comments

@jbusche
Copy link
Collaborator

jbusche commented Jul 19, 2023

@asm582 has a PR 475 that fixes the roles for quota management, but it was pointed out by @sutaakar that the roles also needed to be adjusted in the CodeFlare Operator here:

Just a note - roles need to be also adjusted in operator kubebuilder - https://github.com/project-codeflare/codeflare-operator/blob/9c269d0881a0a37166c120963d747b543413df4e/controllers/mcad_controller.go#L106 (and regenerate config files).

Will create a PR that addresses this.
@jbusche jbusche self-assigned this Jul 19, 2023
@jbusche jbusche changed the title Adjust the operator kubebuilder mcad roles to for quota trees PR Adjust the operator kubebuilder mcad roles for quota trees PR Aug 16, 2023
@jbusche jbusche mentioned this issue Aug 17, 2023
Closed
4 tasks
@jbusche jbusche moved this from Todo to In Progress in Project CodeFlare Sprint Board Aug 17, 2023
@jbusche
Copy link
Collaborator Author

jbusche commented Aug 17, 2023

Created PR 240 to address this

@anishasthana anishasthana moved this from In Progress to Ready For Review in Project CodeFlare Sprint Board Aug 22, 2023
@jbusche jbusche moved this from Ready For Review to In Progress in Project CodeFlare Sprint Board Sep 11, 2023
@jbusche jbusche mentioned this issue Sep 12, 2023
Merged
3 tasks
@jbusche
Copy link
Collaborator Author

jbusche commented Sep 12, 2023

Closed PR 240 an have re-done to catch all the latest CRD changes in PR 283

@github-project-automation github-project-automation bot moved this from In Progress to Done in Project CodeFlare Sprint Board Sep 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jbusche jbusche

Labels
None yet
Projects
Project CodeFlare Sprint Board
Status: Done
Milestone
No milestone
1 participant
@jbusche