Skip to content

Copy MCAD CRDs in Kustomize config instead of referencing them #353

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Tracked by #314
astefanutti opened this issue Oct 18, 2023 · 0 comments · Fixed by #357
Closed
Tracked by #314

Copy MCAD CRDs in Kustomize config instead of referencing them #353

astefanutti opened this issue Oct 18, 2023 · 0 comments · Fixed by #357
Assignees

Comments

@astefanutti
Copy link
Contributor

Currently MCAD CRDs are included by references:

- github.com/project-codeflare/multi-cluster-app-dispatcher/config/crd?ref=v0.0.0 # kpt-set: ${MCAD_CRD}

This used to work as they were dereferenced during the build of the OLM bundle.

Now that the CFO is managed by the ODH operator v2 using plain Kustomize manifests, they must be dereferenced beforehand, also because it'll be required for disconnected environments.

That can be added as extra commands run in the manifests target for example:

$(SED) -i -E "s|(- )\${MCAD_REPO}.*|\1\${MCAD_CRD}|" config/crd/mcad/kustomization.yaml
$(KUSTOMIZE) build config/crd/mcad > config/crd/mcad.yaml

And remove the inclusion of the mcad directory from the config/crd/kustomization.yaml file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging a pull request may close this issue.

2 participants