add unit test for OAuth create

Signed-off-by: Kevin <[email protected]>

Author: KPostOffice

src/codeflare_sdk/utils/openshift_oauth.py

@@ -7,6 +7,9 @@
 from kubernetes import client
 
 
+def _get_api_host(api_client: client.ApiClient):
+    return parse_url(api_client.configuration.host).host
+
 def create_openshift_oauth_objects(cluster_name, namespace):
     config_check()
     api_client = api_config_handler()
@@ -15,7 +18,7 @@ def create_openshift_oauth_objects(cluster_name, namespace):
     tls_secret_name = _gen_tls_secret_name(cluster_name)
     service_name = f"{cluster_name}-oauth"
     port_name = "oauth-proxy"
-    host = parse_url(api_client.configuration.host).host
+    host = _get_api_host(api_client)
 
     # replace "^api" with the expected host
     host = f"{gen_dashboard_route_name(cluster_name)}-{namespace}.apps" + host.lstrip(

tests/unit_test.py

@@ -42,6 +42,7 @@
     config_check,
     api_config_handler,
 )
+from codeflare_sdk.utils.openshift_oauth import create_openshift_oauth_objects
 from codeflare_sdk.utils.pretty_print import (
     print_no_resources_found,
     print_app_wrappers_status,
@@ -2294,6 +2295,30 @@ def test_export_env():
     )
 
 
+# TODO add checks to make sure that when calling generate oauth objects that the fields that are expected to match do
+def test_create_openshift_oauth(mocker: MockerFixture):
+    create_namespaced_service_account = MagicMock()
+    create_cluster_role_binding = MagicMock()
+    create_namespaced_service = MagicMock()
+    create_namespaced_ingress = MagicMock()
+    mocker.patch.object(client.CoreV1Api, "create_namespaced_service_account", create_namespaced_service_account)
+    mocker.patch.object(client.RbacAuthorizationV1Api, "create_cluster_role_binding", create_cluster_role_binding)
+    mocker.patch.object(client.CoreV1Api, "create_namespaced_service", create_namespaced_service)
+    mocker.patch.object(client.NetworkingV1Api, "create_namespaced_ingress", create_namespaced_ingress)
+    mocker.patch("codeflare_sdk.utils.openshift_oauth._get_api_host", return_value="foo.com")
+    create_openshift_oauth_objects("foo", "bar")
+    create_ns_sa_args = create_namespaced_service_account.call_args
+    create_crb_args = create_cluster_role_binding.call_args
+    create_ns_serv_args = create_namespaced_service.call_args
+    create_ns_ingress_args = create_namespaced_ingress.call_args
+    assert create_ns_sa_args.kwargs["namespace"] == create_ns_serv_args.kwargs["namespace"]
+    assert create_ns_serv_args.kwargs["namespace"] == create_ns_ingress_args.kwargs["namespace"]
+    assert isinstance(create_ns_sa_args.kwargs["body"], client.V1ServiceAccount)
+    assert isinstance(create_crb_args.kwargs["body"], client.V1ClusterRoleBinding)
+    assert isinstance(create_ns_serv_args.kwargs["body"], client.V1Service)
+    assert isinstance(create_ns_ingress_args.kwargs["body"], client.V1Ingress)
+    assert create_ns_serv_args.kwargs["body"].spec.ports[0].name == create_ns_ingress_args.kwargs["body"].spec.rules[0].http.paths[0].backend.service.port.name
+
 # Make sure to always keep this function last
 def test_cleanup():
     os.remove("unit-test-cluster.yaml")