Skip to content

Remove scale-down info for Appwrappers that didn't require a scale-up #175

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Tracked by #174
VanillaSpoon opened this issue Nov 10, 2023 · 0 comments · Fixed by #129
Closed
Tracked by #174

Remove scale-down info for Appwrappers that didn't require a scale-up #175

VanillaSpoon opened this issue Nov 10, 2023 · 0 comments · Fixed by #129
Assignees

Comments

@VanillaSpoon
Copy link
Contributor

WHY

If an appwrapper has an empty ordered instance label, Instascale will be unable to scaleup. This is to be expected, and a log notifies the user of the behaviour

appwrapper_controller.go:248] Found AW <aw-name> that cannot be scaled due to missing orderedinstance label

Upon deleting the appwrapper, you'll be notified of a scale down, even though there are no resources to scale down.

Appwrapper deleted scale-down node pool: <aw-name>

This is minor, however, may lead to confusion

DONE

If an appwrapper does not require resources to scale up, ensure there is no logging suggesting a scaledown.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging a pull request may close this issue.

1 participant