Skip to content

Review MCAD build and release instructions #394

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
sutaakar opened this issue May 24, 2023 · 4 comments · Fixed by #403
Closed

Review MCAD build and release instructions #394

sutaakar opened this issue May 24, 2023 · 4 comments · Fixed by #403
Assignees

Comments

@sutaakar
Copy link
Contributor

MCAD is providing build instruction in https://github.com/project-codeflare/multi-cluster-app-dispatcher/blob/main/doc/build/build.md

Review the instructions, check if they cover also releasing of MCAD in case of new version. Add possible missing release information into readme.

@romeokienzler
Copy link

romeokienzler commented Jun 15, 2023

@sutaakar maybe it is useful to (automatically) build the binary (via gh actions) and add it to the release section

@romeokienzler
Copy link

romeokienzler commented Jun 15, 2023

...also finding the --quiet option in make images a little quiet :) ... so seeing the output actually would increase confidence in the build...

@sutaakar
Copy link
Contributor Author

@romeokienzler Can the binary be leveraged by users or is MCAD used just as image?
Trying to figure out what value will it bring.

@z103cb
Copy link
Contributor

z103cb commented Jun 16, 2023

...also finding the --quiet option in make images a little quiet :) ... so seeing the output actually would increase confidence in the build...

There would be no objection on PR to remove the quiet flag.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging a pull request may close this issue.

4 participants