Skip to content

Require Node.js 10 #341

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
stasm opened this issue Feb 19, 2019 · 5 comments · Fixed by #443
Closed

Require Node.js 10 #341

stasm opened this issue Feb 19, 2019 · 5 comments · Fixed by #443

Comments

@stasm
Copy link
Contributor

stasm commented Feb 19, 2019

All fluent.js packages currently require node >= 8.9.0, which ceased to be the active LTS as of January 2019. The new LTS is Node.js 10 which will remain active until April 2020. See https://github.com/nodejs/Release.

Node.js 10 ships with a native implementation of Intl.PluralRules. We currently use an outdated polyfill which diverges from the spec when it comes to formatting numbers with fractions.

We would also be able to remove two Babel plugins from our testing setup: @babel/plugin-proposal-async-generator-functions and @babel/plugin-proposal-object-rest-spread.

@stasm
Copy link
Contributor Author

stasm commented Feb 20, 2019

We should be careful to not break the consumers of our packages. In particular, addons-linter used by web-ext still target Node.js 8. @EnTeQuAk are you aware of any plans to move to Node.js 10 now that it's the current active LTS?

@EnTeQuAk
Copy link
Contributor

As far as I know web-ext isn't planning to do that move anytime soon, so is addons-linter.

cc @rpl though for clarification.

@stasm
Copy link
Contributor Author

stasm commented Feb 20, 2019

My main reason for filing this issue was to be able to drop the outdated polyfill and use the native PluralRules implementation available in Node.js 10. Unfortunately it seems like the current implementation of PluralRules in Chrome is buggy; @zbraniecki has filed https://bugs.chromium.org/p/v8/issues/detail?id=8866 about it. So we might want to continue using the polyfill for the time being. I filed eemeli/intl-pluralrules#2 to ask if the polyfill could be updated to match the spec wrt. minimumFractionDigits.

@stasm
Copy link
Contributor Author

stasm commented Feb 20, 2019

@EnTeQuAk Thanks, that's good to know. We might want to stick to Node.js 8 for now then.

@stasm
Copy link
Contributor Author

stasm commented Nov 26, 2019

It looks like addons-linter and web-ext both require Node.js 10 now:

According to https://nodejs.org/en/about/releases/ Node.js 8 will be EOL-ed on 31st of December, 2019, which would make January a good time to drop it from Fluent as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants