Skip to content

Unskip the Billion Laughs test #388

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
stasm opened this issue Jul 11, 2019 · 2 comments
Closed

Unskip the Billion Laughs test #388

stasm opened this issue Jul 11, 2019 · 2 comments
Labels
fluent-bundle

Comments

@stasm
Copy link
Contributor

stasm commented Jul 11, 2019

Let's fix it.
@stasm stasm mentioned this issue Jul 11, 2019
Merged
@Pike
Copy link
Contributor

Pike commented Jul 12, 2019

I struggled with this test while doing the python port. It seemed that the cut-off would be something implementation dependent, but the test kinda forced a very particular limit.

As we think about tests and their portability.

@stasm stasm mentioned this issue Jul 17, 2019
Merged
@stasm
Copy link
Contributor Author

stasm commented Jul 18, 2019

Fixed by #395 on the release branch.

@stasm stasm closed this as completed Jul 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
fluent-bundle
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Pike @stasm