Skip to content

Store top-level whitespace in the AST #116

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
stasm opened this issue May 21, 2018 · 2 comments
Open

Store top-level whitespace in the AST #116

stasm opened this issue May 21, 2018 · 2 comments
Labels
FUTURE Ideas and requests to consider after Fluent 1.0 syntax

Comments

@stasm
Copy link
Contributor

stasm commented May 21, 2018

The aid full-length file serialization, the AST could contain the information about the whitespace. For starters, the parser could yield the top-level whitespace between other entries.

@stasm
Copy link
Contributor Author

stasm commented Aug 3, 2018

I'm having seconds thoughts on this one. What can top-level whitespace do that calculating spans between entries (in tooling parsers) can't?

@stasm stasm added the FUTURE Ideas and requests to consider after Fluent 1.0 label Aug 3, 2018
@stasm
Copy link
Contributor Author

stasm commented Aug 3, 2018

As per the OTP triage, I moved this out of the Syntax 0.7 scope into FUTURE. There aren't strong drivers for this feature right now. At Mozilla, compare-locales and cross-channel might benefit from it, but they use their own span-based solution right now (here and here).

Let's consider this in the future, when the issue of storing all whitespace is discussed (#121). We might want to employ a common solution to both the top-level and the in-entry whitespace.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
FUTURE Ideas and requests to consider after Fluent 1.0 syntax
Projects
None yet
Development

No branches or pull requests

1 participant