Skip to content

Should broken Attributes reject the whole Entry? #132

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
stasm opened this issue May 28, 2018 · 1 comment
Closed

Should broken Attributes reject the whole Entry? #132

stasm opened this issue May 28, 2018 · 1 comment

Comments

@stasm
Copy link
Contributor

stasm commented May 28, 2018

Right now, the reference parser uses the repeat combinator for Attributes, which yields a Success even when it succeeds 0 times. This has the interesting consequence of Messages and Terms parsing just fine up until a broken Attribute is encountered.

@stasm
Copy link
Contributor Author

stasm commented Jun 29, 2018

We talked about this in the today's meeting. We decided broken Attributes should not reject the whole Message (nor Term) they're defined in.

Attributes can be checked for existence by static analysis tools and/or by the bindings on the runtime. Producing a valid Message even if one of its attributes is broken is more in line with Fluent's comprehensive error recovery strategy. It will also make it easier to edit Fluent files; starting a new attribute will not break the entire message.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant