Skip to content

Add an intermediate Placeable production for Expressions within Patterns #47

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
stasm opened this issue Jun 8, 2017 · 0 comments
Closed
Milestone

Comments

@stasm
Copy link
Contributor

stasm commented Jun 8, 2017

We currently don't expose the information about the exact position of the { … } placeable in the source. Consider:

foo = foo { bar }
      ^_^          TextElement span
            ^_^    MessageReference span
      ^---------^  Pattern span

The suggested solution is to add an intermediate Placeable node for Expressions which are elements of Patterns:

foo = foo { bar }
      ^_^          TextElement span
            ^_^    MessageReference span
          ^-----^  Pleaceable span
      ^---------^  Pattern span
@stasm stasm changed the title Add the intermediete Placeable production for Expressions within Patterns Add an intermediete Placeable production for Expressions within Patterns Jun 8, 2017
@stasm stasm changed the title Add an intermediete Placeable production for Expressions within Patterns Add an intermediate Placeable production for Expressions within Patterns Jun 8, 2017
@stasm stasm added this to the Syntax 0.4 milestone Jul 11, 2017
@stasm stasm closed this as completed in #52 Aug 9, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant