Skip to content

Commit 939c00f

Browse files
committed
Cleaned up some return/else control flow to be more consistent
1 parent b8aa39d commit 939c00f

File tree

1 file changed

+12
-16
lines changed

1 file changed

+12
-16
lines changed

fluent.runtime/fluent/runtime/resolver.py

+12-16
Original file line numberDiff line numberDiff line change
@@ -95,8 +95,8 @@ def fully_resolve(expr, env):
9595
retval = handle(expr, env)
9696
if isinstance(retval, text_type):
9797
return retval
98-
else:
99-
return fully_resolve(retval, env)
98+
99+
return fully_resolve(retval, env)
100100

101101

102102
@singledispatch
@@ -196,25 +196,22 @@ def lookup_reference(ref, env):
196196
"""
197197
ref_id = reference_to_id(ref)
198198

199-
message = None
200199
try:
201-
message = env.context._messages_and_terms[ref_id]
200+
return env.context._messages_and_terms[ref_id]
202201
except LookupError:
203202
env.errors.append(unknown_reference_error_obj(ref_id))
204203

205204
if isinstance(ref, AttributeExpression):
205+
# Fallback
206206
parent_id = reference_to_id(ref.ref)
207207
try:
208-
message = env.context._messages_and_terms[parent_id]
208+
return env.context._messages_and_terms[parent_id]
209209
except LookupError:
210210
# Don't add error here, because we already added error for the
211211
# actual thing we were looking for.
212212
pass
213213

214-
if message is None:
215-
message = FluentNone(ref_id)
216-
217-
return message
214+
return FluentNone(ref_id)
218215

219216

220217
@handle.register(FluentNone)
@@ -285,8 +282,8 @@ def select_from_variant_list(variant_list, env, key):
285282
found = default
286283
if found is None:
287284
return FluentNone()
288-
else:
289-
return handle(found.value, env)
285+
286+
return handle(found.value, env)
290287

291288

292289
@handle.register(SelectExpression)
@@ -312,8 +309,7 @@ def select_from_select_expression(expression, env, key):
312309
found = default
313310
if found is None:
314311
return FluentNone()
315-
else:
316-
return handle(found.value, env)
312+
return handle(found.value, env)
317313

318314

319315
def is_number(val):
@@ -329,9 +325,8 @@ def match(val1, val2, env):
329325
if not is_number(val2):
330326
# Could be plural rule match
331327
return env.context._plural_form(val1) == val2
332-
else:
333-
if is_number(val2):
334-
return match(val2, val1, env)
328+
elif is_number(val2):
329+
return match(val2, val1, env)
335330

336331
return val1 == val2
337332

@@ -370,6 +365,7 @@ def handle_call_expression(expression, env):
370365
with env.modified_for_term_reference(args=kwargs):
371366
return handle(term, env)
372367
else:
368+
# builtin or custom function call
373369
function_name = expression.callee.id.name
374370
try:
375371
function = env.context._functions[function_name]

0 commit comments

Comments
 (0)