Filter expected metrics as well in CollectAndCompare

DariaKunoichi · DariaKunoichi · commit 2e1481973b3b · 2022-10-03T16:02:40.000+02:00
Signed-off-by: Daria Danilenko &lt;daria.danilenko@fluxninja.com&gt;
diff --git a/prometheus/testutil/testutil.go b/prometheus/testutil/testutil.go
@@ -238,6 +238,7 @@ func convertReaderToMetricFamily(reader io.Reader) ([]*dto.MetricFamily, error)
 func compareMetricFamilies(got, expected []*dto.MetricFamily, metricNames ...string) error {
 	if metricNames != nil {
 		got = filterMetrics(got, metricNames)
+		expected = filterMetrics(expected, metricNames)
 	}
 
 	return compare(got, expected)

Original file line number	Diff line number	Diff line change
`@@ -238,6 +238,7 @@ func convertReaderToMetricFamily(reader io.Reader) ([]*dto.MetricFamily, error)`
`238`	`238`	`func compareMetricFamilies(got, expected []*dto.MetricFamily, metricNames ...string) error {`
`239`	`239`	`if metricNames != nil {`
`240`	`240`	`got = filterMetrics(got, metricNames)`
	`241`	`+ expected = filterMetrics(expected, metricNames)`
`241`	`242`	`}`
`242`	`243`
`243`	`244`	`return compare(got, expected)`