Skip to content

Extract common exporter functionality into a package #166

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
fabxc opened this issue Aug 21, 2015 · 4 comments
Closed

Extract common exporter functionality into a package #166

fabxc opened this issue Aug 21, 2015 · 4 comments

Comments

@fabxc
Copy link
Contributor

fabxc commented Aug 21, 2015

As we want to make writing exporters easier with the next version we should provide some helpers to generate a landing page. They are basically copy/paste for the existing exporters.

@beorn7 beorn7 added this to the v0.9 milestone Sep 1, 2016
@grobie
Copy link
Member

grobie commented Oct 14, 2016

Agreed. @beorn7 just pointed me to this issue during a discussion about extraction common boiler plate from exporters. I'd like to make it easier to write exporters in client_golang by providing a framework which handles a set of common features (landing page, version printing, desc handling (might be solved by #222), common struct layout for descriptions, etc.). I'll follow up with some suggestions once I'm released from my SoundCloud duties.

@grobie grobie changed the title Provide landing page helper Extract common exporter functionality into a package Oct 14, 2016
@discordianfish
Copy link
Member

@grobie I'd love that. I've probably written dozens of tiny exporters and feel the pain.
Also wondering if we could improve the UX around finding and deploying an exporter.

For finding maybe some registry you can browse when looking for exporters? They could even get vetted, so you know which one provides the best/most idiomatic metrics.

@beorn7
Copy link
Member

beorn7 commented May 19, 2018

I'll remove this from the v0.9 milestone. This would definitely be useful to have, but it would go into a separate package anyway and there is little need to delay the 0.9 release for it. If it happens in time, great, but if not, no big deal.

@beorn7 beorn7 removed this from the v0.9 milestone May 19, 2018
@beorn7
Copy link
Member

beorn7 commented Jun 3, 2020

The work in this will happen in https://github.com/prometheus/exporter-toolkit . Closing it here.

@beorn7 beorn7 closed this as completed Jun 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants