Skip to content

Improve the way custom collectors for larger numbers of metrics can be written. #182

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
beorn7 opened this issue Nov 9, 2015 · 3 comments
Assignees
Milestone

Comments

@beorn7
Copy link
Member

beorn7 commented Nov 9, 2015

Examples:
https://github.com/mesosphere/mesos_exporter/blob/master/master.go#L75
https://github.com/google/cadvisor/blob/master/metrics/prometheus.go#L91

Is there a better way?

@beorn7 beorn7 self-assigned this Nov 9, 2015
@brian-brazil
Copy link
Contributor

https://github.com/prometheus/client_python#custom-collectors is what Python has which is about as short as I think is possible. Given that Go is a bit more verbose, I'd say what we have is likely as good as it gets.

@beorn7 beorn7 added this to the v0.10 milestone Jan 5, 2017
@beorn7
Copy link
Member Author

beorn7 commented Jan 5, 2017

Adding this to the v0.10 milestone because it should be implemented with the updated interfaces of v0.10, if it will be implemented at all.

@beorn7
Copy link
Member Author

beorn7 commented Feb 13, 2020

#222 should cover what can be done here.

@beorn7 beorn7 closed this as completed Feb 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants