Skip to content

No more Char #42

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
justinwoo opened this issue Jun 2, 2018 · 3 comments
Open

No more Char #42

justinwoo opened this issue Jun 2, 2018 · 3 comments

Comments

@justinwoo
Copy link
Collaborator

I really don't think Char helps here in any way, since that's not even a thing in JS and now we have some ambiguity between CodeUnits and CodePoints. Can we be rid of this and properly use String types wherever we have Strings?
@anttih
Copy link

anttih commented Jun 1, 2019 •
edited
Loading

I just noticed while glancing over the implementation that CodePoints uses charAt in anyChar which deals with code units instead of code points. So either it should return a CodePoint or a String as you suggested.

@anttih anttih mentioned this issue Jun 1, 2019
Closed
@thomashoneyman thomashoneyman mentioned this issue Sep 18, 2019
Merged
@hdgarrood
Copy link
Contributor

I'd prefer to make a decision on purescript/purescript#3662 first.

@github-actions
Copy link

This issue is stale because it has been open for 60 days with no activity. Remove the stale label or comment to keep this issue open. Otherwise, this issue will be closed in 14 days.

@github-actions github-actions bot added the stale label Sep 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@anttih @hdgarrood @justinwoo @thomashoneyman