Skip to content

Handle failed creation better #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
hdgarrood opened this issue Dec 31, 2015 · 3 comments · Fixed by #47
Closed

Handle failed creation better #3

hdgarrood opened this issue Dec 31, 2015 · 3 comments · Fixed by #47
Labels
status: needs more info This issue needs more info before any action can be done.

Comments

@hdgarrood
Copy link
Member

Currently, Node.ChildProcess.spawn with a non-existent executable will return a ChildProcess which isn't "real". For example, its pid will be undefined. This is not ideal.

Currently, you have to handle this by calling onError. Unfortunately, onError is used for other failure conditions that do not happen immediately; see the Node docs.

It's not currently clear to me how best to handle this.

@paluh
Copy link

paluh commented May 17, 2018

@hdgarrood Won't Nullable Int just work in this case? I can provide PR if you agree.

@hdgarrood
Copy link
Member Author

If I remember correctly I considered that option and found that it had some drawback, but I now don’t remember what it was. I’ll check again soon once my exams are over. If it has been a month and I haven’t responded again please feel free to ping me on this thread.

@paluh
Copy link

paluh commented May 20, 2018

@hdgarrood Thanks for the response and good luck on your exams!

@JordanMartinez JordanMartinez added the status: needs more info This issue needs more info before any action can be done. label Dec 7, 2021
@JordanMartinez JordanMartinez mentioned this issue Jul 20, 2023
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: needs more info This issue needs more info before any action can be done.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants