Form doesn't support onSubmit #45

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Closed

f-f opened this issue Jul 20, 2018 · 3 comments

f-f commented Jul 20, 2018 •

edited

Loading

According to React documentation, form elements should support the following events:

onChange
onInput
onInvalid
onSubmit

However, they don't seem to be accepted as props in the definition of form

The text was updated successfully, but these errors were encountered:

Contributor

justinwoo commented Jul 20, 2018

Keep in mind you're linking to code that is generated: https://github.com/lumihq/purescript-react-basic/blob/master/src/React/Basic/DOM.purs#L130

The problem is upstream https://github.com/lumihq/purescript-react-basic/blob/master/codegen/package.json#L8 https://github.com/jackyho112/react-html-attributes

Author

f-f commented Jul 20, 2018

You're right, opened jackyho112/react-html-attributes#11

also /cc @vapaj

Contributor

justinwoo commented Jul 23, 2018

That package now has a newer release, so someone should update the codegen project and run it again

zudov mentioned this issue

Update DOM so that <form> has various 'on*' props #48

Merged

maddie927 closed this as completed in #48

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment