Skip to content

Breaking change introduced #68

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
pete-murphy opened this issue Feb 9, 2022 · 1 comment · Fixed by #69
Closed

Breaking change introduced #68

pete-murphy opened this issue Feb 9, 2022 · 1 comment · Fixed by #69

Comments

@pete-murphy
Copy link
Contributor

pete-murphy commented Feb 9, 2022

I inadvertently added (what I think would be considered) a breaking change here: #55.

That added some unnamed type class instances, which are only supported in PureScript >= 0.14.2. purescript-react-basic-dom specifies a purescript version at ^0.14.0 and a purescript-web-html version at ^3.0.0, which can apparently resolve to [email protected] and [email protected] which are incompatible and leads to the CI breaking for that library: purescript-react/purescript-react-basic-dom#26. I'm raising the issue here since I could imagine other libraries being similarly affected.

I can open a PR that adds names to those instances if that's acceptable.

@thomashoneyman
Copy link
Contributor

Ugh, I totally forgot about this. Yes, please open a PR that adds names to the instances and we can release it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants