diff --git a/bench/Main.purs b/bench/Main.purs new file mode 100644 index 0000000..87c1ca0 --- /dev/null +++ b/bench/Main.purs @@ -0,0 +1,57 @@ +module Bench.Main where + +import Prelude + +import Control.Monad.Eff (Eff) +import Control.Monad.Eff.Console (CONSOLE, log) +import Data.Array.NonEmpty (fromArray) +import Data.Maybe (fromJust) +import Data.String (toCharArray) +import Data.String.NonEmpty (fromFoldable1, fromNonEmptyCharArray) +import Partial.Unsafe (unsafePartial) +import Performance.Minibench (benchWith) + +main :: Eff (console :: CONSOLE) Unit +main = do + log "NonEmpty conversions" + log "======" + log "" + benchNonEmptyConversions + +benchNonEmptyConversions :: Eff (console :: CONSOLE) Unit +benchNonEmptyConversions = do + log "fromNonEmptyCharArray: short" + log "---" + benchFromNonEmptyCharArray + log "" + + log "fromFoldable1" + log "---" + benchFromFoldable1 + log "" + + where + + benchFromNonEmptyCharArray = do + log "short string" + bench \_ -> fromNonEmptyCharArray shortStringArr + + log "long string" + bench \_ -> fromNonEmptyCharArray longStringArr + + benchFromFoldable1 = do + log "short string" + bench \_ -> fromFoldable1 shortStringArr + + log "long string" + bench \_ -> fromFoldable1 longStringArr + + shortStringArr = unsafePartial fromJust $ fromArray + $ toCharArray "supercalifragilisticexpialidocious" + longStringArr = unsafePartial fromJust $ fromArray + $ toCharArray loremIpsum + + bench = benchWith 100000 + +loremIpsum :: String +loremIpsum = "Lorem ipsum dolor sit amet, consectetur adipiscing elit. Ut aliquet euismod ligula, vitae lacinia lorem imperdiet nec. Nulla volutpat ullamcorper mollis. Proin interdum quam a sem auctor, id tempus nisl pretium. Suspendisse potenti. Quisque ut libero consequat, suscipit sem a, malesuada nisi. Aliquam dictum odio mi, eu laoreet felis scelerisque non. Ut in odio vehicula, cursus augue sed, tincidunt lorem. Vestibulum consequat lectus eu commodo vulputate. Nam vitae faucibus ipsum. Curabitur sit amet neque sed est sagittis vehicula nec nec risus. Phasellus consectetur cursus malesuada. Vestibulum commodo lorem ut mauris mollis faucibus. Integer ut massa auctor, scelerisque nisi nec, rutrum nisl. Integer vel ex sem. Sed purus felis, molestie eget cursus vel, maximus ut augue. Curabitur nunc ligula, lobortis vitae vehicula a, volutpat nec sem. Phasellus non sapien ipsum. Mauris dolor justo, mollis at elit a, sollicitudin commodo quam. Curabitur posuere felis at nunc pharetra, eu convallis lectus dapibus. Aliquam ullamcorper porta fermentum. Donec at tellus metus. Donec pharetra tempor odio sit amet viverra. Nam vel metus libero. Vivamus maximus quis lacus id pharetra. Duis sed diam molestie, sodales leo id, pulvinar justo. In non augue tempor risus consectetur hendrerit. In libero nulla, elementum non ultrices eu, vehicula non ipsum. Maecenas in hendrerit tellus, sodales dignissim turpis. Ut odio diam, convallis in elit non, consequat gravida nisi. Cras egestas metus eleifend sapien efficitur, vel vulputate est porta. Aliquam posuere, magna nec bibendum luctus, quam risus efficitur sapien, id volutpat metus ex non lorem. Praesent velit eros, efficitur sed tortor quis, lobortis eleifend ligula. Sed tellus quam, aliquet vitae sagittis a, egestas eget massa. Etiam odio elit, hendrerit vel dui vel, fermentum pharetra neque. Curabitur quis mauris id lacus consectetur rhoncus non nec mauris. Mauris blandit tempor pretium. Donec non nisi finibus, lobortis dolor vitae, euismod arcu. Nullam scelerisque lacus in dolor volutpat mollis. Nunc vitae consectetur ligula, quis laoreet quam.Proin sit amet nisi eu orci hendrerit imperdiet vitae sit amet leo. Donec sodales id ante eget viverra. Nullam vitae elit in mauris accumsan feugiat id a velit. Nulla facilisi. Cras in turpis efficitur, consectetur justo quis, suscipit tortor. Sed tincidunt pellentesque sapien, in ultricies eros rhoncus sit amet. Integer blandit ornare lobortis. Duis dictum sit amet mauris sit amet cursus. Nullam nec nisl mauris. Praesent cursus imperdiet mi mattis luctus. Donec in tortor fermentum, efficitur turpis vel, facilisis augue. Integer egestas nisl et magna volutpat ornare. Donec pulvinar risus elit, eget viverra est feugiat in.Ut nec ante vestibulum neque pulvinar pretium sit amet eu nisi. Aliquam erat volutpat. Maecenas egestas nisi et mi congue, sed ultricies nibh posuere. Suspendisse potenti. Donec a nulla et velit elementum pretium. Pellentesque gravida imperdiet sem et varius. Praesent ac diam diam. Donec iaculis risus ex, ac eleifend sapien luctus ut. Fusce aliquet, lacus tincidunt porta malesuada, massa augue commodo nulla, ac malesuada tortor est sed eros. Praesent mattis, nisi eget ullamcorper vestibulum, lacus ante placerat metus, ac ullamcorper ante tellus vel nulla. Praesent vehicula in est sit amet varius. Sed facilisis felis sed sem porttitor rutrum. Etiam sollicitudin erat neque, id gravida metus scelerisque quis. Proin venenatis pharetra lectus ac auctor." diff --git a/bower.json b/bower.json index 1fe3ac2..225c8bc 100644 --- a/bower.json +++ b/bower.json @@ -27,6 +27,7 @@ }, "devDependencies": { "purescript-assert": "#compiler/0.12", - "purescript-console": "#compiler/0.12" + "purescript-console": "#compiler/0.12", + "purescript-minibench": "#compiler/0.12" } } diff --git a/package.json b/package.json index 132cefc..64f4ac9 100644 --- a/package.json +++ b/package.json @@ -3,7 +3,10 @@ "scripts": { "clean": "rimraf output && rimraf .pulp-cache", "build": "eslint src && pulp build -- --censor-lib --strict", - "test": "pulp test" + "test": "pulp test", + "bench:build": "purs compile 'bench/**/*.purs' 'src/**/*.purs' 'bower_components/*/src/**/*.purs'", + "bench:run": "node --expose-gc -e 'require(\"./output/Bench.Main/index.js\").main()'", + "bench": "npm run bench:build && npm run bench:run" }, "devDependencies": { "eslint": "^3.17.1", diff --git a/src/Data/String/NonEmpty.purs b/src/Data/String/NonEmpty.purs index b3d93a9..0fdd629 100644 --- a/src/Data/String/NonEmpty.purs +++ b/src/Data/String/NonEmpty.purs @@ -10,12 +10,14 @@ module Data.String.NonEmpty , fromString , unsafeFromString , fromCharArray + , fromNonEmptyCharArray , singleton , cons , snoc , fromFoldable1 , toString , toCharArray + , toNonEmptyCharArray , charAt , charCodeAt , toChar @@ -52,6 +54,8 @@ module Data.String.NonEmpty import Prelude +import Data.Array.NonEmpty (NonEmptyArray) +import Data.Array.NonEmpty as NEA import Data.Foldable (class Foldable) import Data.Foldable as F import Data.Maybe (Maybe(..), fromJust) @@ -60,6 +64,7 @@ import Data.Semigroup.Foldable as F1 import Data.String (Pattern(..)) import Data.String as String import Data.String.Unsafe as U +import Partial.Unsafe (unsafePartial) import Unsafe.Coerce (unsafeCoerce) -- | A string that is known not to be empty. @@ -110,6 +115,9 @@ fromCharArray = case _ of [] -> Nothing cs -> Just (NonEmptyString (String.fromCharArray cs)) +fromNonEmptyCharArray :: NonEmptyArray Char -> NonEmptyString +fromNonEmptyCharArray = unsafePartial fromJust <<< fromCharArray <<< NEA.toArray + -- | Creates a `NonEmptyString` from a character. singleton :: Char -> NonEmptyString singleton = NonEmptyString <<< String.singleton @@ -181,6 +189,10 @@ toChar (NonEmptyString s) = String.toChar s toCharArray :: NonEmptyString -> Array Char toCharArray (NonEmptyString s) = String.toCharArray s +-- | Converts the `NonEmptyString` into a non-empty array of characters. +toNonEmptyCharArray :: NonEmptyString -> NonEmptyArray Char +toNonEmptyCharArray = unsafePartial fromJust <<< NEA.fromArray <<< toCharArray + -- | Appends a string to this non-empty string. Since one of the strings is -- | non-empty we know the result will be too. -- | diff --git a/src/Data/String/Regex.js b/src/Data/String/Regex.js index 2e3ac3b..0b84c5b 100644 --- a/src/Data/String/Regex.js +++ b/src/Data/String/Regex.js @@ -46,7 +46,7 @@ exports._match = function (just) { return function (r) { return function (s) { var m = s.match(r); - if (m == null) { + if (m == null || m.length === 0) { return nothing; } else { for (var i = 0; i < m.length; i++) { diff --git a/src/Data/String/Regex.purs b/src/Data/String/Regex.purs index d60b9ee..79a1a9f 100644 --- a/src/Data/String/Regex.purs +++ b/src/Data/String/Regex.purs @@ -18,6 +18,7 @@ module Data.String.Regex import Prelude +import Data.Array.NonEmpty (NonEmptyArray) import Data.Either (Either(..)) import Data.Maybe (Maybe(..)) import Data.String (Pattern(..), contains) @@ -82,13 +83,13 @@ foreign import _match -> (forall r. Maybe r) -> Regex -> String - -> Maybe (Array (Maybe String)) + -> Maybe (NonEmptyArray (Maybe String)) -- | Matches the string against the `Regex` and returns an array of matches -- | if there were any. Each match has type `Maybe String`, where `Nothing` -- | represents an unmatched optional capturing group. -- | See [reference](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/String/match). -match :: Regex -> String -> Maybe (Array (Maybe String)) +match :: Regex -> String -> Maybe (NonEmptyArray (Maybe String)) match = _match Just Nothing -- | Replaces occurences of the `Regex` with the first string. The replacement diff --git a/test/Test/Data/String/NonEmpty.purs b/test/Test/Data/String/NonEmpty.purs index e9cd771..0df3aaf 100644 --- a/test/Test/Data/String/NonEmpty.purs +++ b/test/Test/Data/String/NonEmpty.purs @@ -2,12 +2,13 @@ module Test.Data.String.NonEmpty (testNonEmptyString) where import Data.String.NonEmpty -import Effect (Effect) -import Effect.Console (log) +import Data.Array.NonEmpty as NEA import Data.Array.Partial as AP import Data.Foldable (class Foldable, foldl) import Data.Maybe (Maybe(..), fromJust, isNothing, maybe) import Data.Semigroup.Foldable (class Foldable1, foldMap1Default) +import Effect (Effect) +import Effect.Console (log) import Partial.Unsafe (unsafePartial) import Prelude (class Functor, Ordering(..), Unit, append, discard, negate, not, ($), (&&), (/=), (==)) import Test.Assert (assert) @@ -22,6 +23,9 @@ testNonEmptyString = do assert $ fromCharArray [] == Nothing assert $ fromCharArray ['a', 'b'] == Just (nes "ab") + log "fromNonEmptyCharArray" + assert $ fromNonEmptyCharArray (NEA.singleton 'b') == singleton 'b' + log "singleton" assert $ singleton 'a' == nes "a" @@ -64,6 +68,10 @@ testNonEmptyString = do assert $ toCharArray (nes "ab") == ['a', 'b'] assert $ toCharArray (nes "Hello☺\n") == ['H','e','l','l','o','☺','\n'] + log "toNonEmptyCharArray" + assert $ toNonEmptyCharArray (nes "ab") + == unsafePartial fromJust (NEA.fromArray ['a', 'b']) + log "appendString" assert $ appendString (nes "Hello") " world" == nes "Hello world" assert $ appendString (nes "Hello") "" == nes "Hello" diff --git a/test/Test/Data/String/Regex.purs b/test/Test/Data/String/Regex.purs index 0faaae2..326b35e 100644 --- a/test/Test/Data/String/Regex.purs +++ b/test/Test/Data/String/Regex.purs @@ -1,16 +1,16 @@ module Test.Data.String.Regex (testStringRegex) where -import Prelude (Unit, ($), (<>), discard, (==), not) - -import Effect (Effect) -import Effect.Console (log) +import Data.String.Regex +import Data.Array.NonEmpty (NonEmptyArray, fromArray) import Data.Either (isLeft) -import Data.Maybe (Maybe(..)) -import Data.String.Regex +import Data.Maybe (Maybe(..), fromJust) import Data.String.Regex.Flags (global, ignoreCase, noFlags) import Data.String.Regex.Unsafe (unsafeRegex) - +import Effect (Effect) +import Effect.Console (log) +import Partial.Unsafe (unsafePartial) +import Prelude (type (~>), Unit, discard, not, ($), (<<<), (<>), (==)) import Test.Assert (assert) testStringRegex :: Effect Unit @@ -26,7 +26,8 @@ testStringRegex = do assert $ "quxbarquxbaz" == replace (unsafeRegex "foo" (global <> ignoreCase)) "qux" "foobarFOObaz" log "match" - assert $ match (unsafeRegex "^abc$" noFlags) "abc" == Just [Just "abc"] + assert $ match (unsafeRegex "^abc$" noFlags) "abc" == Just (nea [Just "abc"]) + assert $ match (unsafeRegex "^abc$" noFlags) "xyz" == Nothing log "replace" assert $ replace (unsafeRegex "-" noFlags) "!" "a-b-c" == "a!b-c" @@ -50,3 +51,6 @@ testStringRegex = do let pattern = unsafeRegex "a" (parseFlags "g") assert $ test pattern "a" assert $ test pattern "a" + +nea :: Array ~> NonEmptyArray +nea = unsafePartial fromJust <<< fromArray