Merge pull request #302 from pusher/fix/290-carthage-xcode-12-workaround

Carthage Xcode 12 build failures workaround

Author: danielrbrowne

Consumption-Tests/LATEST_SUPPORTED_XCODE_VERSION

@@ -1 +1 @@
-Xcode 11.7
+Xcode 12.0.1

Consumption-Tests/Shared/carthage-checkout.sh

@@ -128,7 +128,9 @@ echo "git \"file://$REPO_ROOT_ABS_DIR_PATH\" \"$TEMP_TAG_NAME\"" > "$WORKING_DIR
 set +e
 
 # Perform the `carthage update` (using the Cartfile we just created/updated)
-carthage update
+# (`./carthage.sh update` instead of `carthage update` as a workaround for Carthage Xcode 12 issue: https://github.com/Carthage/Carthage/issues/3019#issuecomment-665136323)
+DIR="$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)"
+source ${DIR}/carthage.sh update
 CARTHAGE_UPDATE_STATUS_CODE=$?
 echo "CARTHAGE_UPDATE_STATUS_CODE=$CARTHAGE_UPDATE_STATUS_CODE"
 

Consumption-Tests/Shared/carthage.sh

@@ -0,0 +1,17 @@
+#!/usr/bin/env bash
+
+# carthage.sh
+# Usage example: ./carthage.sh build --platform iOS
+
+set -euo pipefail
+
+xcconfig=$(mktemp /tmp/static.xcconfig.XXXXXX)
+trap 'rm -f "$xcconfig"' INT TERM HUP EXIT
+
+# For Xcode 12 make sure EXCLUDED_ARCHS is set to arm architectures otherwise
+# the build will fail on lipo due to duplicate architectures.
+echo 'EXCLUDED_ARCHS__EFFECTIVE_PLATFORM_SUFFIX_simulator__NATIVE_ARCH_64_BIT_x86_64__XCODE_1200 = arm64 arm64e armv7 armv7s armv6 armv8' >> $xcconfig
+echo 'EXCLUDED_ARCHS = $(inherited) $(EXCLUDED_ARCHS__EFFECTIVE_PLATFORM_SUFFIX_$(EFFECTIVE_PLATFORM_SUFFIX)__NATIVE_ARCH_64_BIT_$(NATIVE_ARCH_64_BIT)__XCODE_$(XCODE_VERSION_MAJOR))' >> $xcconfig
+
+export XCODE_XCCONFIG_FILE="$xcconfig"
+carthage "$@"

README.md

@@ -126,6 +126,10 @@ Carthage will produce a number of frameworks. Which of those you need to include
 - If you **are not** using the end-to-end encryption features, you need to include the following framework binaries from the `Carthage/Build` directory: `PusherSwift` and `Reachability`
 - If you **are** using the end-to-end encryption features, you need to include the following framework binaries from the `Carthage/Build` directory: `PusherSwiftWithEncryption`, `Sodium` and `Reachability`
 
+#### Xcode 12 considerations
+
+Using Carthage under Xcode 12.0 and above currently requires [a workaround](https://github.com/Carthage/Carthage/issues/3019) in order for the build to be successful. You can find an example of the workaround, which is used for running the 'Consumption-Tests' [here](Consumption-Tests/Shared/carthage.sh).
+
 ### Swift Package Manager
 
 > Please note that if you are looking to use encrypted channels, this is not currently possible with Swift Package Manager.