Address code review comments

Author: markcampanelli

README.md

@@ -32,7 +32,7 @@ Installation
 pvlib-python releases may be installed using the ``pip`` and ``conda`` tools.
 Please see the [Installation page](http://pvlib-python.readthedocs.io/en/latest/installation.html) of the documentation for complete instructions.
 
-pvlib-python is compatible with Python 3.5-7.
+pvlib-python is compatible with Python 3.5 and above.
 
 **Python 2.7 support ended on June 1, 2019, with pvlib-python 0.6.3.**
 

docs/environment.yml

@@ -3,29 +3,18 @@ channels:
     - conda-forge
     - defaults
 dependencies:
-    - coveralls
-    - cython
-    - ephem
-    - ipython
-    - matplotlib
-    - netcdf4
-    - nose
-    - numba
-    - numpy
-    - pandas
-    - pip
-    - pytables  # tables when using pip+PyPI
-    - pytest
-    - pytest-cov
-    - pytest-mock
-    - pytest-timeout
     - python=3.6
-    - pytz
-    - requests
+    - numpy=1.14.2
     - scipy
-    - shapely  # pvfactors dependency
-    - siphon  # conda-forge
-    - sphinx
-    - sphinx_rtd_theme
-    - pip:
-        - pvfactors==1.0.1
+    - pytables
+    - pandas=0.22.0
+    - pytz
+    - ephem
+    - numba
+    - ipython=6.3
+    - matplotlib=2.2.2
+    - siphon=0.7.0
+    - sphinx=1.7.2
+    - netCDF4=1.3.1
+    - hdf4=4.2.12
+    - sphinx_rtd_theme

docs/sphinx/source/conf.py

@@ -16,10 +16,8 @@
 import os
 
 # Mock modules so RTD works
-try:
-    from mock import Mock as MagicMock
-except ImportError:
-    from unittest.mock import MagicMock
+from unittest.mock import MagicMock
+
 
 class Mock(MagicMock):
     @classmethod

docs/sphinx/source/contributing.rst

@@ -196,7 +196,7 @@ pvlib python generally follows the `PEP 8 -- Style Guide for Python Code
 <https://www.python.org/dev/peps/pep-0008/>`_. Maximum line length for code
 is 79 characters.
 
-Code must be compatible with Python 3.5-7.
+Code must be compatible with Python 3.5 and above.
 
 pvlib python uses a mix of full and abbreviated variable names. See
 :ref:`variables_style_rules`. We could be better about consistency.

docs/sphinx/source/installation.rst

@@ -201,8 +201,7 @@ Any changes that you make to this pvlib-python will be available inside
 your environment. If you run a git checkout, branch, or pull command the
 result will be applied to your pvlib-python installation. This
 is great for development. Note, however, that you will need to use
-Python's ``reload`` function (`python 2
-<https://docs.python.org/2/library/functions.html#reload>`_, `python 3
+Python's ``reload`` function (`python 3
 <https://docs.python.org/3/library/importlib.html#importlib.reload>`_)
 if you make changes to pvlib during an interactive Python
 session (including a Jupyter notebook). Restarting the Python
@@ -216,7 +215,7 @@ environment) when you start a new shell or terminal.
 Compatibility
 -------------
 
-pvlib-python is compatible with Python 3.5-7.
+pvlib-python is compatible with Python 3.5 and above.
 
 pvlib-python requires Pandas and Numpy. The minimum version requirements
 are specified in

pvlib/__init__.py

@@ -1,10 +1,3 @@
-# First ensure proper Python version.
-import sys
-if not ((3, 5) <= sys.version_info and sys.version_info < (3, 8)):
-    raise RuntimeError("Current Python version is {}.{}.{}, but pvlib-python \
-is only compatible with Python 3.5-7.".format(
-        sys.version_info[0], sys.version_info[1], sys.version_info[2]))
-
 from pvlib.version import __version__
 from pvlib import tools
 from pvlib import atmosphere

setup.py

@@ -38,15 +38,15 @@
 URL = 'https://github.com/pvlib/pvlib-python'
 
 INSTALL_REQUIRES = ['numpy >= 1.10.1',
-                    'pandas >= 0.16.0',
+                    'pandas >= 0.18.0',
                     'pytz',
                     'requests']
 TESTS_REQUIRE = ['nose', 'pytest', 'pytest-cov', 'pytest-mock',
                  'pytest-timeout']
 EXTRAS_REQUIRE = {
-    'optional': ['scipy', 'tables', 'numba', 'siphon', 'netcdf4',
-                 'ephem', 'cython', 'pvfactors == 1.0.1'],
-    'doc': ['sphinx', 'ipython', 'sphinx_rtd_theme', 'matplotlib'],
+    'optional': ['ephem', 'cython', 'netcdf4', 'numba', 'pvfactors', 'scipy',
+                 'siphon', 'tables'],
+    'doc': ['ipython', 'matplotlib', 'sphinx', 'sphinx_rtd_theme'],
     'test': TESTS_REQUIRE
 }
 EXTRAS_REQUIRE['all'] = sorted(set(sum(EXTRAS_REQUIRE.values(), [])))