Fix a minor and inconsequential inconsistency in copyable_holder_caster: the correct load_value() return type is void (as defined in type_caster_generic)

rwgk · rwgk · commit 54fd55911759 · 2024-07-18T00:51:10.000-07:00
For easy future reference, this is the long-standing inconsistency: * https://github.com/pybind/pybind11/blob/dbf848aff7c37ef8798bc9459a86193e28b1032f/include/pybind11/detail/type_caster_base.h#L634 * https://github.com/pybind/pybind11/blob/dbf848aff7c37ef8798bc9459a86193e28b1032f/include/pybind11/cast.h#L797 Noticed in passing while working on PR #5213.
diff --git a/include/pybind11/cast.h b/include/pybind11/cast.h
@@ -794,11 +794,11 @@ struct copyable_holder_caster : public type_caster_base<type> {
         }
     }
 
-    bool load_value(value_and_holder &&v_h) {
+    void load_value(value_and_holder &&v_h) {
         if (v_h.holder_constructed()) {
             value = v_h.value_ptr();
             holder = v_h.template holder<holder_type>();
-            return true;
+            return;
         }
         throw cast_error("Unable to cast from non-held to held instance (T& to Holder<T>) "
 #if !defined(PYBIND11_DETAILED_ERROR_MESSAGES)

Original file line number	Diff line number	Diff line change
`@@ -794,11 +794,11 @@ struct copyable_holder_caster : public type_caster_base<type> {`
`794`	`794`	`}`
`795`	`795`	`}`
`796`	`796`
`797`		`- bool load_value(value_and_holder &&v_h) {`
	`797`	`+ void load_value(value_and_holder &&v_h) {`
`798`	`798`	`if (v_h.holder_constructed()) {`
`799`	`799`	`value = v_h.value_ptr();`
`800`	`800`	`holder = v_h.template holder<holder_type>();`
`801`		`- return true;`
	`801`	`+ return;`
`802`	`802`	`}`
`803`	`803`	`throw cast_error("Unable to cast from non-held to held instance (T& to Holder<T>) "`
`804`	`804`	`#if !defined(PYBIND11_DETAILED_ERROR_MESSAGES)`