Skip to content

Commit d2ca050

Browse files
committed
fixup! update: address review points
1 parent 4b79fcf commit d2ca050

File tree

2 files changed

+2
-4
lines changed

2 files changed

+2
-4
lines changed

CMakeLists.txt

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -46,8 +46,6 @@ message(STATUS "pybind11 v${pybind11_VERSION} ${PYBIND11_VERSION_TYPE}")
4646
if(CMAKE_CURRENT_SOURCE_DIR STREQUAL CMAKE_SOURCE_DIR)
4747
set(PYBIND11_MASTER_PROJECT ON)
4848
message(STATUS "CMake ${CMAKE_VERSION}")
49-
message(STATUS "CXX Compiler: ${CMAKE_CXX_COMPILER}")
50-
message(STATUS "CXX Compiler version: ${CMAKE_CXX_COMPILER_VERSION}")
5149

5250
if(CMAKE_CXX_STANDARD)
5351
set(CMAKE_CXX_EXTENSIONS OFF)

docs/compiling.rst

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -97,7 +97,7 @@ Configuration variables
9797
-----------------------
9898

9999
By default, pybind11 will compile modules with the compiler default or the
100-
minimum standard required by PyBind11, whichever is higher. You can set the
100+
minimum standard required by pybind11, whichever is higher. You can set the
101101
standard explicitly with
102102
`CMAKE_CXX_STANDARD <https://cmake.org/cmake/help/latest/variable/CMAKE_CXX_STANDARD.html>`_:
103103

@@ -124,7 +124,7 @@ For example:
124124
# Another method:
125125
cmake -DPYTHON_EXECUTABLE=/path/to/python ..
126126
127-
# You will often see this idiom:
127+
# This often is a good way to get the current Python, works in environments:
128128
cmake -DPYTHON_EXECUTABLE=$(python3 -c "import sys; print(sys.executable)") ..
129129
130130
find_package vs. add_subdirectory

0 commit comments

Comments
 (0)