Revert "Adding --keep-going"

This reverts commit 1c844c6.

Author: rwgk

.github/workflows/ci.yml

@@ -106,18 +106,18 @@ jobs:
         ${{ matrix.args }}
 
     - name: Build C++11
-      run: cmake --build . -j 2 -- --keep-going
+      run: cmake --build . -j 2
 
     - name: Python tests C++11
       run: cmake --build . --target pytest -j 2
 
     - name: C++11 tests
       # TODO: Figure out how to load the DLL on Python 3.8+
       if: "!(runner.os == 'Windows' && (matrix.python == 3.8 || matrix.python == 3.9 || matrix.python == '3.10-dev'))"
-      run: cmake --build .  --target cpptest -j 2 -- --keep-going
+      run: cmake --build .  --target cpptest -j 2
 
     - name: Interface test C++11
-      run: cmake --build . --target test_cmake_build -- --keep-going
+      run: cmake --build . --target test_cmake_build
 
     - name: Clean directory
       run: git clean -fdx
@@ -134,18 +134,18 @@ jobs:
         ${{ matrix.args2 }}
 
     - name: Build
-      run: cmake --build build2 -j 2 -- --keep-going
+      run: cmake --build build2 -j 2
 
     - name: Python tests
       run: cmake --build build2 --target pytest
 
     - name: C++ tests
       # TODO: Figure out how to load the DLL on Python 3.8+
       if: "!(runner.os == 'Windows' && (matrix.python == 3.8 || matrix.python == 3.9 || matrix.python == '3.10-dev'))"
-      run: cmake --build build2 --target cpptest -- --keep-going
+      run: cmake --build build2 --target cpptest
 
     - name: Interface test
-      run: cmake --build build2 --target test_cmake_build -- --keep-going
+      run: cmake --build build2 --target test_cmake_build
 
     # Eventually Microsoft might have an action for setting up
     # MSVC, but for now, this action works:
@@ -234,13 +234,13 @@ jobs:
         -DCMAKE_CXX_STANDARD=17
 
     - name: Build
-      run: cmake --build build -j 2 -- --keep-going
+      run: cmake --build build -j 2
 
     - name: Python tests
       run: cmake --build build --target pytest
 
     - name: C++ tests
-      run: cmake --build build --target cpptest -- --keep-going
+      run: cmake --build build --target cpptest
 
     - name: Run Valgrind on Python tests
       if: matrix.valgrind
@@ -289,16 +289,16 @@ jobs:
         -DPYTHON_EXECUTABLE=$(python3 -c "import sys; print(sys.executable)")
 
     - name: Build
-      run: cmake --build build -j 2 -- --keep-going
+      run: cmake --build build -j 2
 
     - name: Python tests
       run: cmake --build build --target pytest
 
     - name: C++ tests
-      run: cmake --build build --target cpptest -- --keep-going
+      run: cmake --build build --target cpptest
 
     - name: Interface test
-      run: cmake --build build --target test_cmake_build -- --keep-going
+      run: cmake --build build --target test_cmake_build
 
 
   # Testing NVCC; forces sources to behave like .cu files
@@ -318,7 +318,7 @@ jobs:
       run: cmake -S . -B build -DPYBIND11_CUDA_TESTS=ON -DPYBIND11_WERROR=ON -DDOWNLOAD_CATCH=ON
 
     - name: Build
-      run: cmake --build build -j2 --verbose -- --keep-going
+      run: cmake --build build -j2 --verbose
 
     - name: Python tests
       run: cmake --build build --target pytest
@@ -400,7 +400,7 @@ jobs:
 
     # Building before installing Pip should produce a warning but not an error
     - name: Build
-      run: cmake3 --build build -j 2 --verbose -- --keep-going
+      run: cmake3 --build build -j 2 --verbose
 
     - name: Install CMake with pip
       run: |
@@ -411,10 +411,10 @@ jobs:
       run: cmake3 --build build --target pytest
 
     - name: C++ tests
-      run: cmake3 --build build --target cpptest -- --keep-going
+      run: cmake3 --build build --target cpptest
 
     - name: Interface test
-      run: cmake3 --build build --target test_cmake_build -- --keep-going
+      run: cmake3 --build build --target test_cmake_build
 
 
   # Testing on GCC using the GCC docker images (only recent images supported)
@@ -457,16 +457,16 @@ jobs:
         -DPYTHON_EXECUTABLE=$(python3 -c "import sys; print(sys.executable)")
 
     - name: Build
-      run: cmake --build build -j 2 -- --keep-going
+      run: cmake --build build -j 2
 
     - name: Python tests
       run: cmake --build build --target pytest
 
     - name: C++ tests
-      run: cmake --build build --target cpptest -- --keep-going
+      run: cmake --build build --target cpptest
 
     - name: Interface test
-      run: cmake --build build --target test_cmake_build -- --keep-going
+      run: cmake --build build --target test_cmake_build
 
 
   # Testing on ICC using the oneAPI apt repo
@@ -515,7 +515,7 @@ jobs:
     - name: Build C++11
       run: |
         set +e; source /opt/intel/oneapi/setvars.sh; set -e
-        cmake --build build-11 -j 2 -v -- --keep-going
+        cmake --build build-11 -j 2 -v
 
     - name: Python tests C++11
       run: |
@@ -526,12 +526,12 @@ jobs:
     - name: C++ tests C++11
       run: |
         set +e; source /opt/intel/oneapi/setvars.sh; set -e
-        cmake --build build-11 --target cpptest -- --keep-going
+        cmake --build build-11 --target cpptest
 
     - name: Interface test C++11
       run: |
         set +e; source /opt/intel/oneapi/setvars.sh; set -e
-        cmake --build build-11 --target test_cmake_build -- --keep-going
+        cmake --build build-11 --target test_cmake_build
 
     - name: Configure C++17
       run: |
@@ -547,7 +547,7 @@ jobs:
     - name: Build C++17
       run: |
         set +e; source /opt/intel/oneapi/setvars.sh; set -e
-        cmake --build build-17 -j 2 -v -- --keep-going
+        cmake --build build-17 -j 2 -v
 
     - name: Python tests C++17
       run: |
@@ -558,12 +558,12 @@ jobs:
     - name: C++ tests C++17
       run: |
         set +e; source /opt/intel/oneapi/setvars.sh; set -e
-        cmake --build build-17 --target cpptest -- --keep-going
+        cmake --build build-17 --target cpptest
 
     - name: Interface test C++17
       run: |
         set +e; source /opt/intel/oneapi/setvars.sh; set -e
-        cmake --build build-17 --target test_cmake_build -- --keep-going
+        cmake --build build-17 --target test_cmake_build
 
 
   # Testing on CentOS (manylinux uses a centos base, and this is an easy way
@@ -614,16 +614,16 @@ jobs:
         -DPYTHON_EXECUTABLE=$(python3 -c "import sys; print(sys.executable)")
 
     - name: Build
-      run: cmake --build build -j 2 -- --keep-going
+      run: cmake --build build -j 2
 
     - name: Python tests
       run: cmake --build build --target pytest
 
     - name: C++ tests
-      run: cmake --build build --target cpptest -- --keep-going
+      run: cmake --build build --target cpptest
 
     - name: Interface test
-      run: cmake --build build --target test_cmake_build -- --keep-going
+      run: cmake --build build --target test_cmake_build
 
 
   # This tests an "install" with the CMake tools
@@ -758,7 +758,7 @@ jobs:
         -DDOWNLOAD_EIGEN=ON
         ${{ matrix.args }}
     - name: Build C++11
-      run: cmake --build build -j 2 -- --keep-going
+      run: cmake --build build -j 2
 
     - name: Run tests
       run: cmake --build build -t pytest
@@ -804,7 +804,7 @@ jobs:
         -DDOWNLOAD_EIGEN=ON
 
     - name: Build C++14
-      run: cmake --build build -j 2 -- --keep-going
+      run: cmake --build build -j 2
 
     - name: Run all checks
       run: cmake --build build -t check
@@ -855,7 +855,7 @@ jobs:
         ${{ matrix.args }}
 
     - name: Build ${{ matrix.std }}
-      run: cmake --build build -j 2 -- --keep-going
+      run: cmake --build build -j 2
 
     - name: Run all checks
       run: cmake --build build -t check