Skip to content

Commit f6c7cee

Browse files
committed
Bug fix in test. Minor comment enhancements.
1 parent 3391bbd commit f6c7cee

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

include/pybind11/detail/common.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -661,7 +661,7 @@ template <class T>
661661
using remove_cvref_t = typename remove_cvref<T>::type;
662662
#endif
663663

664-
/// Example usage: is_same_ignoring_cvref<T, PyObject *>
664+
/// Example usage: is_same_ignoring_cvref<T, PyObject *>::value
665665
template <typename T, typename U>
666666
using is_same_ignoring_cvref = std::is_same<detail::remove_cvref_t<T>, U>;
667667

tests/test_type_caster_pyobject_ptr.cpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -90,8 +90,8 @@ TEST_SUBMODULE(type_caster_pyobject_ptr, m) {
9090
std::size_t i = 0;
9191
for (; i < vec_obj.size(); i++) {
9292
py::handle h(vec_obj[i]);
93-
if (static_cast<std::size_t>(h.ref_count()) < i) {
94-
break;
93+
if (static_cast<std::size_t>(h.ref_count()) < 2) {
94+
break; // Something is badly wrong.
9595
}
9696
h.dec_ref();
9797
}

0 commit comments

Comments
 (0)