-
Notifications
You must be signed in to change notification settings - Fork 2.2k
Pybind11 doesn't compile with CPython 3.9b1 #2224
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
The fix for A simple |
The PyThreadState_DeleteCurrent() was supposed to be restored, per @wjakob's request: #1932 and https://bugs.python.org/issue38266 - there was a brief mention of adding an underscore, but it was not supposed to be added. |
Are we sure it is that easy in Pybind11, considering the ability to transfer GIL from one thread to another?
It was removed in python/cpython#15315. |
Docs are being fixed: python/cpython#20489 (review) |
python/cpython#20489 is merged. This only leaves Ping @wjakob |
This can be closed. |
CPython recently released version 3.9.0b1. As is the wonderful custom, it comes with breaking changes.
PyEval_InitThreads()
is deprecated and now does exactly nothing.PyThreadState_DeleteCurrent()
is "removed", or rather renamed to_PyThreadState_DeleteCurrent()
. This one was never documented and the reason for the rename is "why would anyone ever use this function?"The text was updated successfully, but these errors were encountered: